chore: remove unused half_block_cell test helper

[detail-app]

Remove the unused half_block_cell#[cfg(test)] helper function and its sole,
self-referential test half_block_cells_use_block_glyphs_without_color from
src/commands/satisfying_sort/render.rs.

The helper had no production callers (production render_halfblocks_logo inlines
its own glyph-selection logic), and its only consumer was a test that exercised the
helper itself without verifying production behavior.

History

• Last materially changed February 2026 (feat(fun): simplify and modularize terminal animation #118@sachiniyer)

---

Dead Code PRs can be configured here.

---

---

Summary by cubic

Removes the unused half_block_cell test helper and its self-referential test from src/commands/satisfying_sort/render.rs. Production behavior does not change; render_halfblocks_logo already inlines glyph selection.

Review notes

• Deletions are #[cfg(test)] only; there are no production callers.
• No migration or rollout steps.

^{Written for commit f7aaa7d. Summary will update on new commits.}

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR is not ready to merge (currently in state pending): this PR has not been approved.

Pending Status Checks

• ✅ 7 tests passing!

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.