Uh oh!
There was an error while loading. Please reload this page.
chore: remove simulate_old_pagination test helper and its test - #338
Open
detail-app[bot] wants to merge 1 commit into
Open
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the test helper
simulate_old_paginationand theold_pagination_drops_resolved_bugs_issue_300test.simulate_old_paginationre-implemented the old shared-offsetfetch_page_multi_statusalgorithm that was deleted from production in PR #301 in favor of the offset+limit/drain approach, and the test was its only consumer. Neither guarded or exercised any live production code path — the replacementnew_pagination_*tests cover the current algorithm.History
bugs list#301@devin-ai-integration[bot])Dead Code PRs can be configured here.
Summary by cubic
Removes the
simulate_old_paginationtest helper and its only test, which re-implemented the deleted shared-offset pagination algorithm. The replacementnew_pagination_*tests already cover the current offset+limit/drain behavior, so this dead code no longer guards any live production path.Written for commit 15604d5. Summary will update on new commits.