Skip to content

chore: remove simulate_old_pagination test helper and its test - #338

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-simulate-old-pagination-test-helper-a-2fb0e7
Open

chore: remove simulate_old_pagination test helper and its test#338
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-simulate-old-pagination-test-helper-a-2fb0e7

Conversation

@detail-app

@detail-appdetail-appBot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Remove the test helper simulate_old_pagination and the old_pagination_drops_resolved_bugs_issue_300 test. simulate_old_pagination re-implemented the old shared-offset fetch_page_multi_status algorithm that was deleted from production in PR #301 in favor of the offset+limit/drain approach, and the test was its only consumer. Neither guarded or exercised any live production code path — the replacement new_pagination_* tests cover the current algorithm.

History


Dead Code PRs can be configured here.


Summary by cubic

Removes the simulate_old_pagination test helper and its only test, which re-implemented the deleted shared-offset pagination algorithm. The replacement new_pagination_* tests already cover the current offset+limit/drain behavior, so this dead code no longer guards any live production path.

Written for commit 15604d5. Summary will update on new commits.

Review in cubic

@detail-app
detail-appBot requested a review from sachiniyerAugust 29, 2026 17:51
@aviator-app

Copy link
Copy Markdown

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@devin-ai-integrationdevin-ai-integrationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@sachiniyer