Uh oh!
There was an error while loading. Please reload this page.
Add plaintext part to multipart emails (#398) - #458
Open
R1MO9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a plaintext (
text/plain) part alongside the existing HTML part for all outgoing emails, so text-preferring clients get a proper plaintext version instead of HTML-only.SESService.ts—sendRawEmailnow accepts optionaltextcontent and emits it as atext/plainpart inside themultipart/alternativecontainer, placed before the HTML part (per RFC 2046 ordering). When no text is provided, behavior is unchanged (HTML-only).EmailService.ts— addedhtmlToText(), a dependency-free HTML→plaintext converter that stripsstyle/scriptblocks, keeps link URLs next to anchor text (so unsubscribe links survive), converts block elements to line breaks, and decodes entities. Applied to the compiled HTML at send time so the plaintext part carries the same unsubscribe footer as the HTML part.email-processor.ts(live worker) and legacyEmailService.sendEmail— now passtext: htmlToText(compiledHtml).CampaignService.ts— campaign test emails now include the plaintext part too.Type of Change
feat:New feature (MINOR version bump)PR Title Format
feat: add plaintext part to multipart emailsTesting
Added 5 new tests:
htmlToText()All 49 tests in the file pass locally.
Checklist
Related Issues
Closes#398