Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 421
fix colors in dashboard#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -46,7 +46,7 @@ export const DeleteContactBook: React.FC<{ | ||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||
| async function onContactBookDelete( | ||||||||||||||||||||||||||||||||||
| values: z.infer<typeof contactBookSchema> | ||||||||||||||||||||||||||||||||||
| values: z.infer<typeof contactBookSchema>, | ||||||||||||||||||||||||||||||||||
| ) { | ||||||||||||||||||||||||||||||||||
| if (values.name !== contactBook.name) { | ||||||||||||||||||||||||||||||||||
| contactBookForm.setError("name", { | ||||||||||||||||||||||||||||||||||
| @@ -65,7 +65,7 @@ export const DeleteContactBook: React.FC<{ | ||||||||||||||||||||||||||||||||||
| setOpen(false); | ||||||||||||||||||||||||||||||||||
| toast.success(`Contact book deleted`); | ||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| @@ -78,7 +78,7 @@ export const DeleteContactBook: React.FC<{ | ||||||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||||||
| <DialogTrigger asChild> | ||||||||||||||||||||||||||||||||||
| <Button variant="ghost" size="sm" className="p-0 hover:bg-transparent "> | ||||||||||||||||||||||||||||||||||
| <Trash2 className="h-[18px] w-[18px] text-red-600/80 hover:text-red-600/70" /> | ||||||||||||||||||||||||||||||||||
| <Trash2 className="h-[18px] w-[18px] text-red/80 hover:text-red/70" /> | ||||||||||||||||||||||||||||||||||
| </Button> | ||||||||||||||||||||||||||||||||||
Comment on lines
79
to
82
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Tidy className and add accessible label Remove trailing space in className and add an aria-label for the icon-only trigger. - <DialogTrigger asChild>- <Button variant="ghost" size="sm" className="p-0 hover:bg-transparent ">- <Trash2 className="h-[18px] w-[18px] text-red/80 hover:text-red/70" />- </Button>- </DialogTrigger>+ <DialogTrigger asChild>+ <Button+ variant="ghost"+ size="sm"+ className="p-0 hover:bg-transparent"+ aria-label={`Delete contact book ${contactBook.name ?? ""}`}+ title="Delete contact book"+ >+ <Trash2 className="h-[18px] w-[18px] text-red/80 hover:text-red/70" />+ </Button>+ </DialogTrigger>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents | ||||||||||||||||||||||||||||||||||
| </DialogTrigger> | ||||||||||||||||||||||||||||||||||
| <DialogContent> | ||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -62,7 +62,7 @@ export const DeleteApiKey: React.FC<{ | ||||||||||||||||||||||||||||||||
| setOpen(false); | ||||||||||||||||||||||||||||||||
| toast.success(`API key deleted`); | ||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| @@ -75,7 +75,7 @@ export const DeleteApiKey: React.FC<{ | ||||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||||
| <DialogTrigger asChild> | ||||||||||||||||||||||||||||||||
| <Button variant="ghost" size="sm"> | ||||||||||||||||||||||||||||||||
| <Trash2 className="h-4 w-4 text-red-600/80" /> | ||||||||||||||||||||||||||||||||
| <Trash2 className="h-4 w-4 text-red/80" /> | ||||||||||||||||||||||||||||||||
| </Button> | ||||||||||||||||||||||||||||||||
Comment on lines
76
to
79
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Icon-only trigger: add accessible label and consistent hover color Add an aria-label for screen readers and align hover color with other delete triggers in this PR. Apply: - <DialogTrigger asChild>- <Button variant="ghost" size="sm">- <Trash2 className="h-4 w-4 text-red/80" />- </Button>- </DialogTrigger>+ <DialogTrigger asChild>+ <Button+ variant="ghost"+ size="sm"+ aria-label={`Delete API key ${apiKey.name ?? ""}`}+ title="Delete API key"+ >+ <Trash2 className="h-4 w-4 text-red/80 hover:text-red/70" />+ </Button>+ </DialogTrigger>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents | ||||||||||||||||||||||||||||||||
| </DialogTrigger> | ||||||||||||||||||||||||||||||||
| <DialogContent> | ||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Icon-only trigger: add aria-label and hover color for parity
Match other delete actions’ hover treatment and expose an accessible label.
📝 Committable suggestion
🤖 Prompt for AI Agents