') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: simplify domain verification emails by KMKoushik · Pull Request #376 · usesend/useSend · GitHub
Skip to content

fix: simplify domain verification emails - #376

Merged
KMKoushik merged 1 commit into
mainfrom
fix/domain-notification-copy
Mar 13, 2026
Merged

fix: simplify domain verification emails#376
KMKoushik merged 1 commit into
mainfrom
fix/domain-notification-copy

Conversation

@KMKoushik

@KMKoushikKMKoushik commented Mar 13, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • remove verification error details from domain verification notification emails
  • keep the success/failure copy focused on whether the domain is verified or needs DNS fixes
  • update both HTML and plain-text notification content paths

Verification

  • pnpm --filter web exec vitest run -c vitest.unit.config.ts src/server/service/domain-service.unit.test.ts src/server/jobs/domain-verification-job.unit.test.ts

Summary by cubic

Simplified domain verification emails by removing verbose error details and focusing the message on success or required DNS fixes. Updated both HTML and plain-text templates and the service to drop verificationError.

  • Refactors
    • Removed verificationError prop and error block from DomainVerificationStatusEmail.
    • Dropped verificationError parameter and usage in sendDomainStatusNotification.
    • Kept clear status message and link to domain settings.

Written for commit b877c8a. Summary will update on new commits.

Summary by CodeRabbit

  • Changes
    • Simplified domain verification status email notifications by removing specific verification error details. Emails now focus on domain status updates only.

@vercel

vercelBot commented Mar 13, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
unsend-marketingReadyReadyPreview, CommentMar 13, 2026 9:20pm

greptile-apps[bot]
greptile-appsBot reviewed Mar 13, 2026
View reviewed changes

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitaiBot commented Mar 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The PR removes the verificationError parameter from domain status notification handling. The DomainVerificationStatusEmail component no longer accepts a verificationError prop, and the sendDomainStatusNotification function signature is updated to exclude this parameter and its usages. Domain verification continues to compute and return verification errors in results, but these errors are no longer included in email notifications. Email body and subject now rely solely on domain status and previous status information.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: removing verification error details from domain verification emails to simplify them.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Mar 13, 2026

Copy link
Copy Markdown

Deploying usesend with Cloudflare Pages Cloudflare Pages

Latest commit:b877c8a
Status: ✅ Deploy successful!
Preview URL:https://c5491bb8.usesend.pages.dev
Branch Preview URL:https://fix-domain-notification-copy.usesend.pages.dev

View logs

@KMKoushik
KMKoushik merged commit d7b196c into mainMar 13, 2026
7 checks passed
@KMKoushik
KMKoushik deleted the fix/domain-notification-copy branch March 13, 2026 21:22
@coderabbitaicoderabbitaiBot mentioned this pull request Apr 21, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KMKoushik