Skip to content

Various Fixes and Improvements for Analytics - #51

Merged
eldadfux merged 14 commits into
mainfrom
feat-remove-error-handling
Feb 20, 2024
Merged

Various Fixes and Improvements for Analytics#51
eldadfux merged 14 commits into
mainfrom
feat-remove-error-handling

Conversation

@PineappleIOnic

@PineappleIOnicPineappleIOnic commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Currently we use a logError function to handle exceptions, this removes my ability to better handle it on where we use the library so this PR removes that and just throws directly to give us better visibility when things go wrong.

This PR also addresses:

  • Made the plausble validate() method use type instead of name
  • Moved tests over to GitHub actions and parallelised them
  • Changes the hubspot contactExists function to use get contact with email propertyId instead of search this should cover edge cases where users have multiple emails assigned to one contact

@PineappleIOnicPineappleIOnic changed the title Remove Error HandlingVarious Fixes and Improvements for AnalyticsFeb 16, 2024
Comment threadsrc/Analytics/Adapter/HubSpot.php Outdated
Comment threadsrc/Analytics/Adapter/Plausible.php
Comment threadtests/Analytics/AnalyticsTest.php Outdated
Comment threadtests/Analytics/AnalyticsTest.php
Comment threadsrc/Analytics/Adapter.php
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Comment threadsrc/Analytics/Adapter.php
Comment threadsrc/Analytics/Adapter/HubSpot.php
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PineappleIOnic@eldadfux@Meldiron