Skip to content

feat: adapt audit schema to query-lib Attribute and Index VOs - #133

Open
abnegate wants to merge 9 commits into
mainfrom
feat-query-lib
Open

feat: adapt audit schema to query-lib Attribute and Index VOs#133
abnegate wants to merge 9 commits into
mainfrom
feat-query-lib

Conversation

@abnegate

@abnegateabnegate commented Aug 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Required by appwrite/appwrite#11649 and appwrite-labs/cloud#5410. Depends on utopia-php/database#823.

Why this approach

Database::createCollection() takes a Collection only. Audit setup now passes new Collection(id:, attributes:, indexes:) built from typed Attribute/Index factories.

Composer pins utopia-php/database to dev-feat-query-lib as 7.0.0 (808f90bf).

Verified

  • Pint on the Collection wrap

Not verified

  • CI on d552413 after the Collection-only wrap

@abnegate
feat: adapt audit schema to query-lib Attribute and Index VOs
85406fa
@abnegate
(chore): allow validators 0.5 alongside 0.4
9c7f6db
Needed so Appwrite can take main's queue 1.3 pin.
@abnegate
Merge branch 'main' into feat-query-lib
fcce114
Take main's validators ^0.5 pin and refresh database feat-query-lib so Attribute/Index/ColumnType stay current.
@abnegate
(fix): reconstruct Attribute VOs and disable persistent PDO in tests
9688d08
ClickHouse was mutating parent Attribute/Index instances in place.
MariaDB tests were also losing event=delete rows because persistent
PDO plus a new adapter per PHPUnit setUp rolled back uncommitted writes.
@github-actions

github-actionsBot commented Aug 21, 2026

Copy link
Copy Markdown

Thanks for contributing! This repository is a read-only mirror; development for this library happens in packages/audit in the utopia-php monorepo. Please open this pull request there instead.

@abnegateabnegate reopened this Aug 21, 2026
@abnegate

abnegate commented Aug 21, 2026

Copy link
Copy Markdown
MemberAuthor

@greptile-apps review

@greptile-apps

greptile-appsBot commented Aug 21, 2026•
edited
Loading

Copy link
Copy Markdown

Greptile Summary

The PR migrates audit schemas and query handling to the typed value objects and method enums provided by the updated Utopia database/query libraries.

  • Replaces array-based attribute and index definitions with Attribute and Index value objects.
  • Passes a typed Collection into database setup.
  • Updates ClickHouse schema translation and query handling for the new value-object APIs.
  • Expands query-library compatibility and refreshes the locked dependency graph.
  • Updates adapter and query tests for typed schema properties and enum-backed methods.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

FilenameOverview
composer.jsonSwitches the database dependency to the query-lib development branch, permits query 0.4/0.5, and adds VCS repositories.
composer.lockLocks the development database revision, query 0.5.0, and the resulting transitive dependency updates.
src/Audit/Adapter/SQL.phpReplaces shared array-based schema definitions with typed Attribute and Index value objects.
src/Audit/Adapter/Database.phpAdapts collection setup and query-method comparisons to the updated database and query APIs.
src/Audit/Adapter/ClickHouse.phpMigrates ClickHouse schema inspection, construction, and query dispatch to typed value objects and method enums.
src/Audit/Query.phpAdds compatibility constants and enum-backed factory overrides around the shared query implementation.
tests/Audit/Adapter/ClickHouseTest.phpUpdates schema assertions and test naming for value-object attributes and indexes.
tests/Audit/Adapter/DatabaseTest.phpDisables persistent PDO connections in the database adapter test setup.
tests/Audit/QueryTest.phpUpdates query assertions for enum-backed method values.

Reviews (7): Last reviewed commit: "(chore): allow utopia-php/query 0.5" | Re-trigger Greptile

@abnegate
(refactor): prefer Attribute and Index typed factories
e1700e5
Schema definitions with a known column or index type now use
Attribute::string() / Index::key() instead of the generic
constructors plus ColumnType / IndexType.
@abnegate
(chore): use caret ranges for Utopia dependencies
8750f1e
Asterisk wildcards on utopia-php packages are replaced with
equivalent caret constraints so Composer ranges stay consistent.
@abnegate
(chore): refresh lockfile after caret Utopia constraints
348a4f8
Keep composer.json and composer.lock in sync so `composer validate`
passes, and pin utopia-php/database to the current query-lib HEAD.
@abnegate

abnegate commented Aug 21, 2026

Copy link
Copy Markdown
MemberAuthor

@greptileai review

This was referenced Aug 21, 2026
Open
Open
@abnegate

abnegate commented Aug 21, 2026

Copy link
Copy Markdown
MemberAuthor

@greptile-apps review

Force re-review of HEAD 348a4f8. Description updated for factories and caret lock refresh.

@abnegate
(feat): pass Collection to createCollection
d552413
Database::createCollection no longer accepts a string id.
@abnegate
(chore): allow utopia-php/query 0.5
e6e2892
Database feat-query-lib now requires query ^0.5 after nested joins.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abnegate