Skip to content

APPW-4366: Add Code Linter To utopia-php/audit - #33

Merged
christyjacob4 merged 3 commits into
utopia-php:masterfrom
Rutam21:APPW-4366
Nov 15, 2022
Merged

APPW-4366: Add Code Linter To utopia-php/audit#33
christyjacob4 merged 3 commits into
utopia-php:masterfrom
Rutam21:APPW-4366

Conversation

@Rutam21

Copy link
Copy Markdown
Contributor

What

This PR aims to resolve the issue appwrite/appwrite#4366.

How

  • Code Linter has been added to utopia-php/audit repository.
  • All existing files are formatted as per the Linting rules.
  • PR Template has been followed as mentioned in Feat: Implement linter ab#7.

Fixesappwrite/appwrite#4366

@Rutam21

Copy link
Copy Markdown
ContributorAuthor

@Meldiron Please review and approve or suggest changes, if any. Thanks.

@MeldironMeldiron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@Rutam21

Copy link
Copy Markdown
ContributorAuthor

@Meldiron I hope this can be merged now and the respective issue can be marked as complete and closed.

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rutam21. sorry, it looks like there are merge conflicts now. Would you please resolve them?

@Rutam21

Copy link
Copy Markdown
ContributorAuthor

@stnguyen90 I have resolved the merge conflicts. This is good to be merged now. LMK if any further changes are needed.

@stnguyen90
stnguyen90 self-requested a review November 14, 2022 21:32

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@christyjacob4
christyjacob4 merged commit 32894b7 into utopia-php:masterNov 15, 2022
@christyjacob4

Copy link
Copy Markdown
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/audit’

4 participants

@Rutam21@christyjacob4@stnguyen90@Meldiron