Skip to content
This repository was archived by the owner on Aug 14, 2026. It is now read-only.

Feat: DB proxy - #1

Merged
eldadfux merged 33 commits into
mainfrom
dev
Feb 27, 2024
Merged

Feat: DB proxy#1
eldadfux merged 33 commits into
mainfrom
dev

Conversation

@Meldiron

@MeldironMeldiron commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator
  • Manual QA with Sentry logging
    CleanShot 2023-10-17 at 15 24 00@2x
    CleanShot 2023-10-17 at 15 24 29@2x
  • All tests in utopia/database passed locally
    image

Comment thread.github/workflows/linter.yml
Comment thread_build.txt Outdated
Comment threadapp/Validator/Assoc.php Outdated
Comment threadapp/endpoints.php Outdated
Comment threadapp/endpoints.php Outdated
Comment threadapp/http.php Outdated
Comment threadapp/http.php Outdated
Comment threadapp/http.php Outdated
Comment threadapp/http.php Outdated

@abnegateabnegate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.

Let's make sure all those tests are added and the auth var issues are sorted too 👍

Comment threadDockerfile Outdated
Comment threadapp/endpoints.php Outdated
Comment threadapp/http.php Outdated
Comment threadapp/http.php Outdated
Comment threadapp/http.php Outdated
Comment threadDockerfile Outdated
Comment threadcomposer.json
Comment threadmariadb.cnf Outdated
Comment threadcomposer.json Outdated
Comment threadpsalm.xml
Comment threadcomposer.json Outdated
Comment threadapp/endpoints.php Outdated
@Meldiron

Copy link
Copy Markdown
CollaboratorAuthor

This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.

Yes, sadly. We could just proxy it, but we won't have any validators and we would be guessing expected classes. That'ß why we decided to define each endpoint.

Thankfully, if you do some change or add new method in utopia-php/database, the DatabaseProxy tests will fails. Thats indicator that you need to add it here too.

Comment threadcomposer.json Outdated
@eldadfux
eldadfux merged commit 85812cd into mainFeb 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Meldiron@eldadfux@abnegate@christyjacob4@fogelito