Skip to content

Fix permission test - #290

Merged
abnegate merged 10 commits into
mainfrom
fix-permission-test
Aug 10, 2023
Merged

Fix permission test#290
abnegate merged 10 commits into
mainfrom
fix-permission-test

Conversation

@fogelito

@fogelitofogelito commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

No description provided.

abnegate
abnegate reviewed Jul 24, 2023
View reviewed changes
Comment threadsrc/Database/Helpers/Permission.php Outdated
Comment threadtests/Database/PermissionTest.php Outdated
fogelitoand others added 2 commits July 25, 2023 10:53
@fogelito
Revert test
5ce693b
@fogelito@abnegate
Update src/Database/Helpers/Permission.php
0cd8488
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
@abnegate

abnegate commented Jul 27, 2023

Copy link
Copy Markdown
Member

@fogelito Some tests are still failing here

fogelito
fogelito commented Jul 31, 2023
View reviewed changes
Comment threadtests/Database/PermissionTest.php Outdated
@github-actionsgithub-actionsBot mentioned this pull request Aug 1, 2023
Closed
stnguyen90
stnguyen90 reviewed Aug 2, 2023
View reviewed changes
Comment threadtests/Database/PermissionTest.php Outdated
Comment threadtests/Database/PermissionTest.php Outdated
stnguyen90
stnguyen90 reviewed Aug 10, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #290 (comment)

abnegate
abnegate reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/Database/Helpers/Permission.php Outdated
@abnegate
abnegate merged commit 5631f15 into mainAug 10, 2023
@github-actionsgithub-actionsBot mentioned this pull request Sep 1, 2023
Closed
@abnegate
abnegate deleted the fix-permission-test branch November 23, 2023 01:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegateabnegateabnegate approved these changes
@stnguyen90stnguyen90Awaiting requested review from stnguyen90

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fogelito@abnegate@stnguyen90