Skip to content

No Exception when no change in update document function - #295

Merged
abnegate merged 8 commits into
mainfrom
fix-no-authorization-exception-no-change-update-document
Jul 26, 2023
Merged

No Exception when no change in update document function#295
abnegate merged 8 commits into
mainfrom
fix-no-authorization-exception-no-change-update-document

Conversation

@fanatic75

@fanatic75fanatic75 commented Jul 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

We should not throw authorization exception when there is no change in update document coming document.
This is required for Relationships as we need to allow users to update document having related collection with no permission.

Part fixappwrite/appwrite#5404

stnguyen90
stnguyen90 suggested changes Jul 18, 2023
View reviewed changes
Comment threadsrc/Database/Database.php Outdated
Comment threadsrc/Database/Database.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
@fanatic75@stnguyen90
Format issues
95b0f94
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
stnguyen90
stnguyen90 approved these changes Jul 24, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll defer to @abnegate for another set of eyes.

fogelito
fogelito reviewed Jul 25, 2023
View reviewed changes
Comment threadtests/Database/Base.php
@fanatic75
fanatic75 requested a review from fogelitoJuly 25, 2023 10:28
abnegate
abnegate reviewed Jul 25, 2023
View reviewed changes
Comment threadsrc/Database/Database.php Outdated
Comment threadsrc/Database/Database.php Outdated
Comment threadtests/Database/Base.php
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
@fanatic75

fanatic75 commented Jul 26, 2023

Copy link
Copy Markdown
ContributorAuthor

@abnegate can you please re-review this

@fanatic75
fanatic75 requested a review from abnegateJuly 26, 2023 05:35
@abnegate
abnegate merged commit a9f7060 into mainJul 26, 2023
This was referenced Aug 1, 2023
Closed
Closed
@abnegate
abnegate deleted the fix-no-authorization-exception-no-change-update-document branch November 23, 2023 01:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegateabnegateabnegate approved these changes
@fogelitofogelitoAwaiting requested review from fogelito
+1 more reviewer
@stnguyen90stnguyen90stnguyen90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Nested update, permission issue

4 participants

@fanatic75@stnguyen90@abnegate@fogelito