Skip to content

Add method for creating a timeout for all find, sum, count queries in timeout supported dbs - #296

Merged
abnegate merged 3 commits into
mainfrom
static-set-timeout
Jul 31, 2023
Merged

Add method for creating a timeout for all find, sum, count queries in timeout supported dbs#296
abnegate merged 3 commits into
mainfrom
static-set-timeout

Conversation

@fanatic75

@fanatic75fanatic75 commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

Asana Task : https://app.asana.com/0/1204806686347431/1205080260273691

This feature creates a way to add a timeout in a static manner

@fanatic75
fanatic75 requested a review from eldadfuxJuly 19, 2023 17:06
abnegate
abnegate reviewed Jul 25, 2023
View reviewed changes
Comment threadsrc/Database/Adapter.php
Comment threadsrc/Database/Adapter.php Outdated
Comment threadsrc/Database/Adapter/Postgres.php Outdated
@fanatic75
fanatic75 requested a review from abnegateJuly 26, 2023 05:17
@fanatic75

fanatic75 commented Jul 26, 2023

Copy link
Copy Markdown
ContributorAuthor

@abnegate I have made changes according to your comments. can you review again?

abnegate
abnegate reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/Database/Adapter/MariaDB.php Outdated
Comment threadsrc/Database/Adapter.php
Comment threadsrc/Database/Adapter/Postgres.php Outdated
@abnegate
abnegate merged commit 5ae3035 into mainJul 31, 2023
This was referenced Aug 1, 2023
Closed
Closed
@abnegate
abnegate deleted the static-set-timeout branch November 23, 2023 01:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegateabnegateabnegate approved these changes
@eldadfuxeldadfuxAwaiting requested review from eldadfux

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanatic75@abnegate