Skip to content

Fix 5871 relationships with non existing documents - #298

Merged
abnegate merged 7 commits into
mainfrom
fix-5871-relationships-with-non-existing-documents
Aug 9, 2023
Merged

Fix 5871 relationships with non existing documents#298
abnegate merged 7 commits into
mainfrom
fix-5871-relationships-with-non-existing-documents

Conversation

@fanatic75

@fanatic75fanatic75 commented Jul 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes bug in multiple relationships

Previously we were getting 500 for one to one two way as the non existing doc needs to be updated in One to One two-way relationship type and non existing doc does not have key.
Now we are keeping it consistent with other relationship types and skipping non existing doc

fanatic75
fanatic75 commented Jul 27, 2023
View reviewed changes
Comment threadsrc/Database/Database.php
fanatic75
fanatic75 commented Jul 27, 2023
View reviewed changes
Comment threadsrc/Database/Database.php
fanatic75
fanatic75 commented Jul 27, 2023
View reviewed changes
Comment threadsrc/Database/Database.php
fanatic75
fanatic75 commented Jul 27, 2023
View reviewed changes
Comment threadsrc/Database/Database.php
stnguyen90
stnguyen90 reviewed Jul 27, 2023
View reviewed changes
Comment threadsrc/Database/Database.php Outdated
Comment threadsrc/Database/Database.php Outdated
@fanatic75@stnguyen90
Updates comment formatting to consistent style
b604cac
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
stnguyen90
stnguyen90 reviewed Jul 29, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/utopia-php/database/pull/298/files#r1278173401

@github-actionsgithub-actionsBot mentioned this pull request Aug 1, 2023
Closed
stnguyen90
stnguyen90 reviewed Aug 1, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#298 (comment)

@fanatic75
add non existing doc check in one-to-one two-way
2973593
Previously we were getting 500 as the non existing doc needs to be updated in two-way relationship type and non existing doc does not have key. Now we are keeping it consistent with other relationship types and skipping non existing doc
abnegate
abnegate reviewed Aug 7, 2023
View reviewed changes
Comment threadsrc/Database/Database.php Outdated
Comment threadsrc/Database/Database.php Outdated
Comment threadsrc/Database/Database.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
Comment threadtests/Database/Base.php Outdated
@fanatic75
fanatic75 requested a review from abnegateAugust 8, 2023 15:54
@abnegate
abnegate merged commit fb7435a into mainAug 9, 2023
@joeyoussjoeyouss mentioned this pull request Aug 16, 2023
Closed
2 tasks
@github-actionsgithub-actionsBot mentioned this pull request Sep 1, 2023
Closed
@abnegate
abnegate deleted the fix-5871-relationships-with-non-existing-documents branch November 23, 2023 01:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegateabnegateabnegate approved these changes
@stnguyen90stnguyen90Awaiting requested review from stnguyen90

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Many-to-Many Relationship Updated with Non Existing Documents

3 participants

@fanatic75@stnguyen90@abnegate