add checking of nested docs id in comparison check when updating document

[fanatic75]

This PR checks the nested docs id to the old doc nested docs.
For example:

If document A is related to document B but we do not have permission to access it, we can still establish a relationship between document A and a different version of document B (let's call it B1). This is because we compare B to its previous version, and B1 to its previous version as well. If there are no changes in B1, then we do not need permission to relate it to document A.

[abnegate]

Let's see if we can simplify some of the conditions to make it a bit easier to read

[abnegate]

We don't need the curly braces around the switch cases

[fanatic75]

can we keep them? It allows me to minimize the whole case at once without curly brackets, it's not possible.

[abnegate]

Let's remove them, they will be inconsistent with other switches, and we shouldn't change code style just for IDE features.

If you're using VS Code, you could change the folding strategy to allow minimizing the whole case without changing code

[abnegate]

Nice looks much better, just a few more style changes 👍

[abnegate]

These two can just be (\is_null($value) !== \is_null($oldValue))

[abnegate]

Let's break from the if instead of nesting in an else

[abnegate]

Let's line break to make ternarys easier to read:

Suggested change

	$oldValue = $old->getAttribute($key) instanceof Document ? $old->getAttribute($key)->getId() : $old->getAttribute($key);
	$oldValue = $old->getAttribute($key) instanceof Document
	? $old->getAttribute($key)->getId()
	: $old->getAttribute($key);

[abnegate]

Let's line break this too

[abnegate]

Suggested change

	(\is_string($relation) && $oldValue!==$relation) ||
	(\is_string($relation) && $oldValue!==$relation) ||

[abnegate]

These two can just be (\is_null($value) !== \is_null($oldValue))

[abnegate]

These two can just be (\is_null($value) !== \is_null($oldValue))

[abnegate]

Suggested change

	if (array_key_exists($key, $relationships)) {
	if (\array_key_exists($key, $relationships)) {