Skip to content

Feat: DB Proxy Adapter - #338

Merged
eldadfux merged 44 commits into
mainfrom
feat-proxy-adapter
Mar 1, 2024
Merged

Feat: DB Proxy Adapter#338
eldadfux merged 44 commits into
mainfrom
feat-proxy-adapter

Conversation

@Meldiron

Copy link
Copy Markdown
Contributor

DB proxy is dedicated HTTP server that maintains all database collections.
Using this proxy instead of separating maximum connection limit between containers allows improvements to scalability. It also prevents many idling connections when they could be used better by another containers.

@Meldiron
Meldiron marked this pull request as ready for review October 16, 2023 13:23
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
Comment threaddocker-compose.yml Outdated
Comment threadsrc/Database/Adapter/Proxy.php Outdated
Comment threadsrc/Database/Adapter/Proxy.php Outdated
Comment threadsrc/Database/Adapter/Proxy.php Outdated
Comment threadsrc/Database/Adapter/ProxyMariaDB.php Outdated
Comment threadsrc/Database/Exception.php Outdated
Comment on lines +5 to +7
use Utopia\Database\Exception;

class Conflict extends Exception

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we check if there's anywhere we need to update the order of catch blocks because of this change (if any sub-types are caught, those catches need to now come before the DatabaseException catch)

]);

static::getDatabase()->createDocument('country', $doc);
static::getDatabase()->createDocument('country', new Document($doc->getArrayCopy()));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-02-29 at 15 08 02@2x

because test is failing without it. Maybe now that its fully stateless, some problem came up

@Meldiron
Meldiron changed the base branch from main to feat-framework-v2February 22, 2024 13:42
@Meldiron
Meldiron changed the base branch from feat-framework-v2 to mainFebruary 22, 2024 13:44
Comment threadphpunit.xml Outdated
Comment threadsrc/Database/Query.php Outdated
Comment threadsrc/Database/Adapter/Proxy.php
@eldadfux
eldadfux merged commit 02000f0 into mainMar 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Meldiron@eldadfux@abnegate@fogelito