Uh oh!
There was an error while loading. Please reload this page.
Feat: Make authorization per-instance - #343
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fix: setAction method
abnegate
left a comment
There was a problem hiding this comment.
Can't comment on the Base.php diff since it's so big 😅 but do we need both the static and instance Authorization instances there?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Meldiron
commented
Jan 8, 2024
|
@Meldiron I mean in the test base class we have an instance var |
Meldiron
commented
Jan 24, 2024
I cant improve this without renaming var in ~100 lines. The setup that is there still make sense - it's not Utopia-spepcfiic, but PHPUnit-specific. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Makes auth validator instance-aware, to make it work fine with corutines server