Skip to content

Fix: remove unique index from collection name#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldadfux merged 2 commits into from
Aug 5, 2021
Merged

Fix: remove unique index from collection name #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
079acfe
Remove unique index from collection name
kodumbeats Aug 5, 2021
6b1e96c
Test for non-unique collection names
kodumbeats Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/Database/Database.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -230,16 +230,7 @@ public function create(): bool
['indexesInQueue', self::VAR_STRING, 1000000, false],
]);

/** @var Document[] $indexes*/
$indexes = [
new Document([
'$id' => '_key_1',
'type' => self::INDEX_UNIQUE,
'attributes' => ['name'],
])
];

$this->createCollection(self::COLLECTIONS, $attributes, $indexes);
$this->createCollection(self::COLLECTIONS, $attributes);

return true;
}
Expand Down
9 changes: 9 additions & 0 deletions tests/Database/Base.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,15 @@ public function testCreateListDeleteCollection()

$this->assertCount(1, static::getDatabase()->listCollections());

// Collection names should not be unique
$this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->createCollection('actors2'));
$this->assertCount(2, static::getDatabase()->listCollections());
$collection = static::getDatabase()->getCollection('actors2');
$collection->setAttribute('name', 'actors'); // change name to one that exists
$this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->updateDocument($collection->getCollection(), $collection->getId(), $collection));
$this->assertEquals(true, static::getDatabase()->deleteCollection('actors2')); // Delete collection when finished
$this->assertCount(1, static::getDatabase()->listCollections());

$this->assertEquals(false, static::getDatabase()->getCollection('actors')->isEmpty());
$this->assertEquals(true, static::getDatabase()->deleteCollection('actors'));
$this->assertEquals(true, static::getDatabase()->getCollection('actors')->isEmpty());
Expand Down