Uh oh!
There was an error while loading. Please reload this page.
Feature - Strict Query Validation - #7
Conversation
eldadfux
commented
May 1, 2021
@kodumbeats I might also add a new collection attributed called "indexesInQueue" to hold pending indexes that are still being created, this will allow us to give a better error messages in this validator. |
@eldadfux I'm not 💯 on what is best to pass to the Queries validator constructor. I landed on this approach in acefb92 because passing in Maybe you have some suggestions on how to best model the new collections in the Queries unit tests: |
eldadfux
left a comment
There was a problem hiding this comment.
Looks very good, left some minor comments. When ready I can merge it and start playing around with it :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR introduces a new Queries validator to validate an array of Query objects by:
Test plan:
Unit tests included
TODO: