fix: re-encode updatedAt in increase/decreaseDocumentAttribute with preserveDates

[premtsd-code]

Problem

When preserveDates is enabled, increaseDocumentAttribute and decreaseDocumentAttribute pass the decoded ISO 8601 $updatedAt (2026-03-10T10:33:54.726+00:00) directly to the SQL adapter, which expects DB format (Y-m-d H:i:s.v). This causes SQLSTATE[22007]: Invalid datetime format on MariaDB.

Other methods like createDocument and updateDocument don't have this issue because they go through the encode() pipeline which handles the conversion.

Fix

Re-encode $updatedAt using DateTime::format() before passing it to the adapter.

Test plan

• Added test for increase/decrease with preserveDates enabled
• Existing increase/decrease tests unaffected

[coderabbitai]

📝 Walkthrough

Walkthrough

This change normalizes existing updatedAt values by converting them to DateTime and reformatting when preserveDates is enabled in attribute increment/decrement methods, and adds tests that assert updatedAt remains unchanged when preservation is enabled.

Changes

Cohort / File(s)	Summary
Date normalization logic src/Database/Database.php	increaseDocumentAttribute and decreaseDocumentAttribute now convert existing updatedAt to \DateTime and format it when preserveDates is true, producing a consistent timestamp string instead of preserving arbitrary input.
Test coverage tests/e2e/Adapter/Scopes/DocumentTests.php	Added testIncreaseDecreasePreserveDates(Document $document): void to verify updatedAt stays the same when preserveDates is enabled (duplicate insertion observed).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Return new value atomically #604 — Modifies increaseDocumentAttribute/decreaseDocumentAttribute; related refactor touches the same methods and transactional/return behavior.
• Refactor DocumentTests to improve test coverage and structure #644 — Also adjusts updatedAt handling when preserveDates is enabled; related normalization changes in update-related methods.

Suggested reviewers

• ArnabChatterjee20k
• abnegate
• fogelito

Poem

🐰 I nudge a timestamp soft and neat,
I wrap it in DateTime's gentle sheet,
Preserved it stays, in tidy form,
Hop, hop—consistent through each storm! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: fixing the re-encoding of updatedAt in increase/decreaseDocumentAttribute methods when preserveDates is enabled, which matches the core fix in the Database.php file.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-preserve-dates-datetime-format

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/e2e/Adapter/Scopes/DocumentTests.php`:
- Around line 1548-1563: The test enables preserveDates via
Database::setPreserveDates(true) but does not guarantee it is reset if an
assertion or operation fails; wrap the section that fetches the document, calls
increaseDocumentAttribute/decreaseDocumentAttribute, and asserts updatedAt in a
try/finally so that Database::setPreserveDates(false) is always executed in the
finally block, ensuring preserveDates is restored regardless of exceptions or
assertion failures.
- Around line 1550-1561: The test currently only asserts updatedAt didn't change
under preserveDates; also assert the numeric attributes actually changed: after
calling $database->increaseDocumentAttribute('increase_decrease',
$document->getId(), 'increase', 1) fetch the document ($after) and assert its
'increase' value equals the original $before->getAttribute('increase') + 1, and
after calling $database->decreaseDocumentAttribute(..., 'decrease', 1) fetch
again and assert 'decrease' equals original $before->getAttribute('decrease') -
1 (use the existing $before, $after variables and the
increaseDocumentAttribute/decreaseDocumentAttribute calls to locate where to add
these assertions).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7bdcae3f-5a79-4a9b-a218-3f2cb0104392

📥 Commits

Reviewing files that changed from the base of the PR and between 438cc82 and 49aa318.

📒 Files selected for processing (2)

• src/Database/Database.php
• tests/e2e/Adapter/Scopes/DocumentTests.php