Skip to content

Framework V2 - #102

Merged
eldadfux merged 90 commits into
masterfrom
feat-v2
Jan 4, 2024
Merged

Framework V2#102
eldadfux merged 90 commits into
masterfrom
feat-v2

Conversation

@lohanidamodar

@lohanidamodarlohanidamodar commented Jul 6, 2023

Copy link
Copy Markdown
Contributor
  • Support server adapters

@lohanidamodar
lohanidamodar changed the base branch from master to feat-routing-v2July 11, 2023 05:33
eldadfux
eldadfux reviewed Jul 11, 2023
View reviewed changes
Comment threadsrc/Adapter/FPM/Server.php Outdated
Comment threadsrc/Adapter/Swoole/Files.php Outdated
eldadfux
eldadfux requested changes Jul 11, 2023
View reviewed changes

@eldadfuxeldadfux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress. We need to test both Swoole and FPM. We should also update the readme file.

What are we doing about server initiali`ation callbacks? Can we make the server init look closer to other newer utopia libs? Take Appwrite for example, we have a lot of usage of Swoole callbacks for server start and other events. Can we abstract that nicely?

Comment threadsrc/Adapter/Swoole/Files.php Outdated
Comment threadsrc/Adapter/Swoole/Server.php Outdated
Comment threadsrc/App.php Outdated
eldadfux
eldadfux requested changes Jul 12, 2023
View reviewed changes
Comment threadDockerfile.swoole
Comment threadREADME.md
Comment threadsrc/Adapter.php Outdated
Comment threadsrc/Adapter.php Outdated
lohanidamodarand others added 4 commits July 12, 2023 10:10
@lohanidamodar@eldadfux
Update src/Adapter.php
136c318
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
@lohanidamodar@eldadfux
Update src/Adapter.php
a3bdb49
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
@lohanidamodar
update dockerfile name
ab04d15
@lohanidamodar
update readme
8b448f6
Meldironand others added 22 commits October 2, 2023 13:05
eldadfux
eldadfux reviewed Jan 4, 2024
View reviewed changes
Comment threadsrc/Http/Adapter/Swoole/Server.php Outdated
Comment threadsrc/Http/Adapter/FPM/Server.php Outdated
Comment threadsrc/View.php
Comment threadtests/e2e/server_fpm.php
Comment threadtests/e2e/server_swoole.php
@eldadfux
eldadfux merged commit dc539ee into masterJan 4, 2024
@github-actionsgithub-actionsBot mentioned this pull request Feb 1, 2024
Closed
@loks0n
loks0n deleted the feat-v2 branch April 24, 2026 09:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MeldironMeldironMeldiron left review comments
@eldadfuxeldadfuxeldadfux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lohanidamodar@eldadfux@Meldiron@vermakhushboo