Skip to content

Issue-4370: Added Code Analyzer To utopia-php/framework - #79

Merged
christyjacob4 merged 10 commits into
utopia-php:masterfrom
Rutam21:APPW-4370
Apr 6, 2023
Merged

Issue-4370: Added Code Analyzer To utopia-php/framework#79
christyjacob4 merged 10 commits into
utopia-php:masterfrom
Rutam21:APPW-4370

Conversation

@Rutam21

@Rutam21Rutam21 commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

What

This PR aims to resolve the issue appwrite/appwrite#4370.

How

  • Code Analyzer has been added to utopia-php/framework repository.
  • All existing files are fixed as per the PhpStan rules at Level 5.
  • PR Template has been followed as mentioned in Feat: Code quality analysis ab#8.

Screenshots

PhpStan Ananlysis

Fixesappwrite/appwrite#4370

@Rutam21

Rutam21 commented Oct 22, 2022

Copy link
Copy Markdown
ContributorAuthor

@Meldiron Please review and approve. Thanks.

@PineappleIOnic

PineappleIOnic commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

stnguyen90
stnguyen90 suggested changes Nov 16, 2022
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Comment threadcomposer.json Outdated
Comment threadsrc/Validator/Range.php Outdated
Comment threadtests/Validator/ArrayListTest.php
Comment threadtests/e2e/server.php Outdated
Comment threadtests/e2e/server.php Outdated
stnguyen90
stnguyen90 previously requested changes Nov 23, 2022
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to address the comments I previously left.

Comment threadcomposer.json Outdated
@stnguyen90
stnguyen90 self-requested a review January 27, 2023 19:08
@christyjacob4

christyjacob4 commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

@Rutam21 thanks a lot for your contributions during Hacktoberfest 2022!

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

@christyjacob4
christyjacob4 merged commit 19d3925 into utopia-php:masterApr 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannTorstenDittmann approved these changes
@christyjacob4christyjacob4christyjacob4 approved these changes
+1 more reviewer
@stnguyen90stnguyen90stnguyen90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🔎 Add Code Analyzer To ‘utopia-php/framework’

5 participants

@Rutam21@PineappleIOnic@christyjacob4@stnguyen90@TorstenDittmann