Skip to content

Feat: Honeybadger adaptor - #19

Open
2002Bishwajeet wants to merge 13 commits into
utopia-php:mainfrom
2002Bishwajeet:feat-honeybadger-adaptor
Open

Feat: Honeybadger adaptor#19
2002Bishwajeet wants to merge 13 commits into
utopia-php:mainfrom
2002Bishwajeet:feat-honeybadger-adaptor

Conversation

@2002Bishwajeet

@2002Bishwajeet2002Bishwajeet commented Oct 25, 2022

Copy link
Copy Markdown

What it does

Fixes#4212

Miscellaneous Changes

  • Changed raw links to the proper markdown page of Contributing and Code of Conduct hyperlinks in add-logger-adaptor.md
  • Minor typo errors

Testing

Manual Testing

Have you read the contributing guidelines?

Always 😉

@2002Bishwajeet

2002Bishwajeet commented Oct 25, 2022

Copy link
Copy Markdown
Author

The test fails due to the unavailability of the honeybadger API key🙂

@PineappleIOnic

PineappleIOnic commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@stnguyen90
stnguyen90 self-requested a review November 17, 2022 01:19
stnguyen90
stnguyen90 suggested changes Nov 17, 2022
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Comment threadtests/LoggerTest.php
Comment threadsrc/Logger/Adapter/HoneyBadger.php Outdated
@christyjacob4

christyjacob4 commented Jan 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@2002Bishwajeet please address the comments

@stnguyen90stnguyen90 mentioned this pull request Jan 20, 2023
Open
@stnguyen90

stnguyen90 commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

Sample generated from test case:

image

image

stnguyen90
stnguyen90 suggested changes Jan 20, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change please! 🙏🏼

Comment threadtests/LoggerTest.php Outdated
@2002Bishwajeet

2002Bishwajeet commented Jan 21, 2023

Copy link
Copy Markdown
Author

@stnguyen90 , I did some work on #24. Request for re-review

stnguyen90
stnguyen90 suggested changes Feb 9, 2023
View reviewed changes
Comment threadsrc/Logger/Adapter/HoneyBadger.php Outdated
@christyjacob4

christyjacob4 commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

@2002Bishwajeet thanks a lot for your contributions during Hacktoberfest 2022! Please address fix the failing tests so we can move forward with this.

Meanwhile you can reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

@christyjacob4
christyjacob4 self-requested a review April 6, 2023 08:29
@2002Bishwajeet

2002Bishwajeet commented Apr 7, 2023

Copy link
Copy Markdown
Author

Updated changes
image

@2002Bishwajeet

2002Bishwajeet commented Apr 7, 2023

Copy link
Copy Markdown
Author

Also while running static code analysis, I get this

Checks took 2.54 seconds and used 154.024MB of memory
Psalm was unable to infer types in the codebase

Not sure if it means success or not

stnguyen90
stnguyen90 suggested changes Apr 24, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some lint errors.

stnguyen90
stnguyen90 suggested changes Aug 1, 2023
View reviewed changes
Comment threadsrc/Logger/Adapter/HoneyBadger.php
foreach ($breadcrumbsObject as $breadcrumb) {
\array_push($breadcrumbsArray, [
'category' => $breadcrumb->getCategory(),
'timestamp' => \intval($breadcrumb->getTimestamp()),

@stnguyen90stnguyen90Aug 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this recently, but got an error in Honeybadger because they expect this to be a string like 2020-01-27T12:37:31.616-08:00. Would you please update this to be a ISO-8601 formatted timestamp in UTC?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christyjacob4christyjacob4Awaiting requested review from christyjacob4
1 more reviewer
@stnguyen90stnguyen90stnguyen90 requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚨 Improve Appwrite Logging with HoneyBadger Adapter

4 participants

@2002Bishwajeet@PineappleIOnic@christyjacob4@stnguyen90