Skip to content

feat: add clicksend-sms-adapter - #15

Merged
abnegate merged 4 commits into
utopia-php:feat-clicksendfrom
josua99:feat-XXX-clicksend-messaging-adapter
Sep 14, 2023
Merged

feat: add clicksend-sms-adapter#15
abnegate merged 4 commits into
utopia-php:feat-clicksendfrom
josua99:feat-XXX-clicksend-messaging-adapter

Conversation

@josua99

@josua99josua99 commented Feb 28, 2023

Copy link
Copy Markdown

What does this PR do?

Implemented a new adapter that connects ClickSend.

Test Plan

I've successfully sent a test SMS using the new ClickSend adapter.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

YES

wemiprog
wemiprog approved these changes Feb 28, 2023
View reviewed changes

@wemiprogwemiprog left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be in line with the other providers. Also not seeing any problem, seems to work.
Clicksend is a nice and important provider, very cheap, simple and universally usable (not affiliated with them).
I‘d vote for approval

abnegate
abnegate reviewed May 19, 2023
View reviewed changes

@abnegateabnegate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor issues. Please address the comments and add a screenshot of a successful send with this adapter 😄

Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
@abnegate

abnegate commented May 19, 2023

Copy link
Copy Markdown
Member

Please also add this adapter to the list of available adapters in the README

@josua99

josua99 commented May 19, 2023

Copy link
Copy Markdown
Author

grafik
screenshot of a successful send with this adapter

abnegate
abnegate reviewed May 19, 2023
View reviewed changes
Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
Comment threadsrc/Utopia/Messaging/Adapters/SMS/ClickSend.php Outdated
@abnegate
abnegate changed the base branch from main to feat-clicksendSeptember 14, 2023 20:57
@abnegate
abnegate merged commit f8314e3 into utopia-php:feat-clicksendSep 14, 2023
@abnegateabnegate mentioned this pull request Sep 14, 2023
Closed
@github-actionsgithub-actionsBot mentioned this pull request Oct 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegateabnegateAwaiting requested review from abnegate
1 more reviewer
@wemiprogwemiprogwemiprog approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josua99@abnegate@wemiprog@jk-inf