Skip to content

Feat adding sms adapters - #16

Merged
abnegate merged 13 commits into
utopia-php:mainfrom
byawitz:feat-adding-sms-adapters
Sep 14, 2023
Merged

Feat adding sms adapters#16
abnegate merged 13 commits into
utopia-php:mainfrom
byawitz:feat-adding-sms-adapters

Conversation

@byawitz

@byawitzbyawitz commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

It added support for the following SMS providers (Adapters)

  • Seven (formerly sms77)
  • Sinch
  • Infobip
  • Clickatell
  • Plivo

Plus I've added one document summarizing and comparing the prices for a single unit and 10K for the implemented providers.

Test Plan

I've run tests on each provider. Plivo I had for a long time and for everyone except Clickatell has a trial.

Related PRs and Issues

#17

Have you read the [Contributing Guidelines on issues]

Yes

@byawitzbyawitz mentioned this pull request Mar 31, 2023
Closed
7 tasks
@stnguyen90

stnguyen90 commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

@byawitz, thanks for the PR! 🙏🏼 it looks like there are some linter problems. Would you please address those? You should be able to run composer format to fix all the lint problems.

@byawitz

byawitz commented Apr 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@stnguyen90 Thanks for your answer

Done

abnegate
abnegate reviewed May 19, 2023
View reviewed changes

@abnegateabnegate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of minor comments. Please address, as well as add some screenshots of successful sends using these adapters 🙏

Comment threadsrc/Utopia/Messaging/Adapters/SMS/Clickatell.php Outdated
Comment threadsrc/Utopia/Messaging/Adapters/SMS/Clickatell.php Outdated
@byawitz

byawitz commented May 31, 2023

Copy link
Copy Markdown
ContributorAuthor

image

I don't know what image I should attach for the verification. Hope this one helps.

Also, @abnegate I've sent you a DM with the test suite code that includes all the API keys for you to test.

@byawitz
byawitz requested a review from abnegateMay 31, 2023 01:12
@abnegate
abnegate merged commit 2d0f474 into utopia-php:mainSep 14, 2023
@github-actionsgithub-actionsBot mentioned this pull request Oct 1, 2023
Closed
@byawitzbyawitz mentioned this pull request Oct 2, 2023
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegateabnegateabnegate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@byawitz@stnguyen90@abnegate