Skip to content

Added Pusher Messaging Adapter - #36

Open
kit-t wants to merge 1 commit into
utopia-php:mainfrom
kit-t:feat-6398-pusher-messaging-adapter
Open

Added Pusher Messaging Adapter#36
kit-t wants to merge 1 commit into
utopia-php:mainfrom
kit-t:feat-6398-pusher-messaging-adapter

Conversation

@kit-t

@kit-tkit-t commented Oct 4, 2023•
edited
Loading

Copy link
Copy Markdown

What does this PR do?

Adds a new Push Adapter for sending push notification via Pusher.

Test Plan

  • Create a free account on Pusher
  • Add the following environment variables
    • PUSHER_INSTANCE_ID: <Pusher Beams instance id, can be found in the dashboard under Keys > Credentials>
    • PUSHER_SECRET_KEY: <Pusher Beams secret key, can be found in the dashboard under Keys > Credentials>
    • PUSHER_TO: <userId e.g. 'test-user-id'>
  • Run test against tests/e2e/Push/PusherTest.php

Related PRs and Issues

resolvesappwrite/appwrite#6398

Have you read the Contributing Guidelines on issues?

Yes

@kit-tkit-t mentioned this pull request Oct 4, 2023
Closed
5 tasks
@kit-t

kit-t commented Oct 24, 2023

Copy link
Copy Markdown
Author

Hi @wess, this is ready for review 🙂

@stnguyen90
stnguyen90 self-requested a review October 31, 2023 15:29
stnguyen90
stnguyen90 suggested changes Oct 31, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you please attach a screenshot of a successful test to verify it all works?

@kit-t

kit-t commented Oct 31, 2023

Copy link
Copy Markdown
Author

Looks good! Would you please attach a screenshot of a successful test to verify it all works?

Sure.
image

@stnguyen90
stnguyen90 self-requested a review November 1, 2023 00:30
stnguyen90
stnguyen90 approved these changes Nov 1, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
@gewenyu99

gewenyu99 commented Apr 8, 2024

Copy link
Copy Markdown

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@kit-t

kit-t commented Apr 9, 2024

Copy link
Copy Markdown
Author

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Discord username: _kit_t

Thanks!

@gewenyu99

gewenyu99 commented Apr 19, 2024

Copy link
Copy Markdown

Will reach out soon after we put together forms for everyone!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MeldironMeldironMeldiron approved these changes
@christyjacob4christyjacob4Awaiting requested review from christyjacob4
+1 more reviewer
@stnguyen90stnguyen90stnguyen90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

💬 Improve Appwrite Messaging with Pusher Adapter

4 participants

@kit-t@gewenyu99@stnguyen90@Meldiron