Skip to content

Added Gupshup Messaging Adapter - #49

Closed
HarshitVashisht11 wants to merge 5 commits into
utopia-php:mainfrom
HarshitVashisht11:main
Closed

Added Gupshup Messaging Adapter#49
HarshitVashisht11 wants to merge 5 commits into
utopia-php:mainfrom
HarshitVashisht11:main

Conversation

@HarshitVashisht11

@HarshitVashisht11HarshitVashisht11 commented Oct 10, 2023

Copy link
Copy Markdown

What does this PR do?

This PR implement support for Gupshup in the Utopia PHP messaging library.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

appwrite/appwrite#6863
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@HarshitVashisht11HarshitVashisht11 changed the title Initial commitSupport for Gupshup in the Utophia-php meassaging libraryOct 11, 2023
@HarshitVashisht11HarshitVashisht11 changed the title Support for Gupshup in the Utophia-php meassaging librarySupport for Gupshup in the Utopia-php meassaging libraryOct 11, 2023
@HarshitVashisht11HarshitVashisht11 changed the title Support for Gupshup in the Utopia-php meassaging libraryAdded Gupshup Messaging AdapterOct 11, 2023

@wesswess left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include tests and be sure to run linter

@wesswess left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to add tests and run the linter (pint)

@gewenyu99

Copy link
Copy Markdown

@HarshitVashisht11 Linter and tests are still failing, did you run linter and tests before submitting the PR?

@HarshitVashisht11HarshitVashisht11 closed this by deleting the head repository Oct 18, 2023
@HarshitVashisht11

Copy link
Copy Markdown
Author

Hi @wess@gewenyu99 i have made a new PR closing this PR because of some issue in commit

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HarshitVashisht11@gewenyu99@wess