Uh oh!
There was an error while loading. Please reload this page.
Conversation
eldadfux
left a comment
There was a problem hiding this comment.
A few suggestions:
- I would add all adapters under an
Adaptersfolder - All categories of adapters could still be at this path fore example:
src/Utopia/Messaging/Adapters/Email/Mailgun.php - With the new directory structure, specific abstract don't need a postfix. For example:
EmailAdapter.phpcan just beEmail.php Messagescould be an independent directory alongsideAdaptersso each entity is independent. No need for aMessagepostfix we can leverage namespaces for that with the new dir structure.- We should prefer shorter naming conventions when possible.
sendMessage()can be justsend()
eldadfux
left a comment
There was a problem hiding this comment.
Great work Jake! Left a few comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| public function getMaxMessagesPerRequest(): int | ||
| { | ||
| return PHP_INT_MAX; |
There was a problem hiding this comment.
We will probably hit HTTP request size limit before that.
There was a problem hiding this comment.
In that case the exception will propagate to the caller, the service has no limit, unless we want to apply an arbitrary one ourselves instead?
There was a problem hiding this comment.
Not sure what might be the best approach, but we would need to take payload size to consideration at some point, either here or in Appwrite itself.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
Adapterclass