Uh oh!
There was an error while loading. Please reload this page.
Escape commands passed to run and execute - #37
Draft
stnguyen90 wants to merge 2 commits into
Draft
Conversation
stnguyen90force-pushed
the
fix-command-escaping
branch
from
March 12, 2024 20:51
d9b1277 to
2c20647Compareabnegate
approved these changes
Mar 12, 2024
stnguyen90force-pushed
the
fix-command-escaping
branch
5 times, most recently
from
March 12, 2024 22:21
fa29780 to
db2bdc3Comparestnguyen90
marked this pull request as draft
March 22, 2024 17:44
stnguyen90
commented
Mar 22, 2024
Author
Need to fix tests. |
stnguyen90force-pushed
the
fix-command-escaping
branch
from
May 10, 2024 20:37
db2bdc3 to
450018eComparestnguyen90
commented
May 10, 2024
Author
The tests are probably failing because the 3rd command is being escaped: orchestration/tests/Orchestration/Base.php Lines 465 to 472 in 450018e |
stnguyen90force-pushed
the
fix-command-escaping
branch
13 times, most recently
from
May 10, 2024 23:39
a6b4bc9 to
aeb9b9aCompareEach element in commands should be treated as a single argument so we should escape it as an argument to prevent anything from breakint out to execute anything else.
stnguyen90force-pushed
the
fix-command-escaping
branch
from
May 10, 2024 23:41
aeb9b9a to
09a11a3Comparestnguyen90force-pushed
the
fix-command-escaping
branch
from
May 13, 2024 23:19
1eb3c7c to
bca3cfcCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each element in commands should be treated as a single argument so we should escape it as an argument to prevent anything from breakint out to execute anything else.