Skip to content

tutorial to add adapter - #8

Merged
lohanidamodar merged 16 commits into
mainfrom
doc-adapter-tutorial
Jul 18, 2023
Merged

tutorial to add adapter#8
lohanidamodar merged 16 commits into
mainfrom
doc-adapter-tutorial

Conversation

@lohanidamodar

@lohanidamodarlohanidamodar commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@lohanidamodar
lohanidamodar requested review from PineappleIOnic, gewenyu99 and stnguyen90 and removed request for PineappleIOnicApril 25, 2023 05:57
gewenyu99
gewenyu99 suggested changes Apr 25, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

Comment threaddocs/tutorials/add-payment-adapter.md Outdated

### 1.1 Fork the utopia-php/pay repository

Before making any changes, you will need to fork Utopia's repository to keep branches on the official repo clean. To do that, visit the [utopia/logger Github repository](https://github.com/utopia-php/pay) and click on the fork button.

@gewenyu99gewenyu99Apr 25, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean to say utopia/payment?

@lohanidamodarlohanidamodarApr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, fixed

stnguyen90
stnguyen90 suggested changes May 3, 2023
View reviewed changes
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
Comment threaddocs/tutorials/add-payment-adapter.md Outdated
lohanidamodarand others added 12 commits May 3, 2023 07:04
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
e0af653
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
26f9f6c
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
cd03c9e
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
5474b27
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
3fab134
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
cb4e908
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
4db5459
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
10f5f68
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
0147a7c
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
01fc623
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
edb039c
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@lohanidamodar@stnguyen90
Apply suggestions from code review
02cfa62
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
stnguyen90
stnguyen90 suggested changes May 4, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this.

Comment threaddocs/tutorials/add-payment-adapter.md Outdated
@lohanidamodar@stnguyen90
Update docs/tutorials/add-payment-adapter.md
0c20a23
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
gewenyu99
gewenyu99 approved these changes May 17, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lohanidamodar
lohanidamodar merged commit 64bd885 into mainJul 18, 2023
@lohanidamodar
lohanidamodar deleted the doc-adapter-tutorial branch July 18, 2023 01:13
@github-actionsgithub-actionsBot mentioned this pull request Aug 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@stnguyen90stnguyen90stnguyen90 approved these changes
@gewenyu99gewenyu99gewenyu99 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lohanidamodar@stnguyen90@gewenyu99