Skip to content

Implement Retry into Queue Lib - #17

Merged
christyjacob4 merged 15 commits into
mainfrom
feat-retry
Jan 17, 2024
Merged

Implement Retry into Queue Lib#17
christyjacob4 merged 15 commits into
mainfrom
feat-retry

Conversation

@PineappleIOnic

Copy link
Copy Markdown
Contributor

This PR implements Retry functionality into the Queue library, it will take all failed jobs in {namespace}.failed.{queue} and re-queue them while removing them from that list.

@PineappleIOnicPineappleIOnic changed the title Finish Initial Retry ImplementationImplement Retry into Queue LibDec 29, 2023
Comment threadtests/Queue/e2e/AdapterTest.php Outdated
Comment threadsrc/Queue/Client.php
Comment threadsrc/Queue/Client.php Outdated
eldadfux
eldadfux previously requested changes Dec 29, 2023
Comment threadtests/Queue/e2e/Adapter/SwooleTest.php Outdated
Comment threadcomposer.json Outdated
Git ignored when I renamed it from e2e to E2E so I had to manually mv it using the cli
@TorstenDittmann

TorstenDittmann commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

How is the retry strategy applied in production?

As far as I can see here right now, is that we manually need to retry and it just works of all failed jobs. I am not sure if this is the most sane approach. Usually with all common libraries, the retry configuration is tied to a job. Meaning you enqueue a job while defining how its going to be retried.

I am not sure if blindly just working of failed jobs is good. We dont know how many times a job has been retried, etc.

ref:

@PineappleIOnic

Copy link
Copy Markdown
ContributorAuthor

Right, I'll try and so some research and think of something better

@eldadfuxeldadfux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the sum method I saw in the Appwrite PR? I can't seem to find it.

Comment threadsrc/Queue/Client.php
Comment threadsrc/Queue/Client.php
Comment threadsrc/Queue/Client.php
Comment threadsrc/Queue/Client.php
Comment threadsrc/Queue/Connection/Redis.php
Comment threadsrc/Queue/Connection/Redis.php
Comment threadtests/Queue/E2E/Adapter/Base.php Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PineappleIOnic@TorstenDittmann@eldadfux@christyjacob4