Added Oracle Object Storage adapter by SaketKaswa20 · Pull Request #91 · utopia-php/storage

SaketKaswa20 · 2023-10-05T18:52:08Z

Added Oracle Object Storage Adapter

Solving Issue #6415

stnguyen90

Great PR! 🤯 We left some comments during the review, please check them out.

Please also make sure to:

to run the formatter to fix the lint errors
attach a screenshot of successful tests

stnguyen90 · 2023-10-12T15:37:57Z

+ * @var string
+ */
+ protected string $root = 'oracle-object';
+


Shouldn't there be region constants?

stnguyen90 · 2023-10-12T15:41:33Z

+ public function __construct(string $root = '')
+ {
+ $this->root = $root;
+ }


There should definitely be more parameters than this like some sort of key and bucket.

Thanks!
Will solve the mentioned things and push the changes.

SaketKaswa20 · 2023-10-14T10:56:55Z

I am facing problem in phpunit test. It is showing could not read phpunit.xml when using phpunit --configuration phpunit.xml and when running vendor/bin/phpunit --configuration phpunit.xml I get the error zsh: no such file or directory: vendor/bin/phpunit.

gewenyu99 · 2023-10-18T03:28:13Z

@stnguyen90 take a peek at the comment here

stnguyen90

Changes still pending.

Discord thread: https://discord.com/channels/564160730845151244/1162704045937541140

stnguyen90

Please see my comments and make sure to run the formatter to fix the lint problems.

stnguyen90 · 2023-10-24T15:14:49Z

+ public function __construct(string $root = '', array $config = [])
+ {
+ $this->root = $root;
+ $this->config = $config;


Let's not use a config array like this. Please take a look at how similar adapters are implemented in this repo to see how the configuration should be implemented.

stnguyen90 · 2023-10-24T15:16:56Z

+use Utopia\Storage\Device;
+use Utopia\Storage\Storage;
+
+class OracleObject extends Device


This should probably extend the S3 adapter because Oracle Object is an S3-compatible storage provider.

stnguyen90 · 2023-10-24T15:21:12Z

+ public function uploadFileToOracleObjectStorage(string $localFilePath, string $remoteFilePath): bool
+ {
+ // Implement logic to upload a file to Oracle Object Storage
+ // Return true on success, false on failure
+ // You should use the Oracle Object Storage SDK or API for this operation
+ return true; // Example: always return true for the sake of testing
+ }
+
+ public function downloadFileFromOracleObjectStorage(string $remoteFilePath, string $localFilePath): bool
+ {
+ // Implement logic to download a file from Oracle Object Storage
+ // Return true on success, false on failure
+ // You should use the Oracle Object Storage SDK or API for this operation
+ return true; // Example: always return true for the sake of testing
+ }
+
+ public function deleteFileFromOracleObjectStorage(string $remoteFilePath): bool
+ {
+ // Implement logic to delete a file from Oracle Object Storage
+ // Return true on success, false on failure
+ // You should use the Oracle Object Storage SDK or API for this operation
+ return true; // Example: always return true for the sake of testing
+ }


These custom functions should be added because this should implement Device such that you would use the same methods from the Device class (like upload and delete).

stnguyen90 · 2023-10-24T15:22:42Z


 const DEVICE_LINODE = 'linode';

+ const DEVICE_ORACLEOBJECT = 'oracleobject';


This should be DEVICE_ORACLE_OBJECT just like DEVICE_DO_SPACES:
Suggested change
constDEVICE_ORACLEOBJECT = 'oracleobject';
constDEVICE_ORACLE_OBJECT = 'oracleobject';

gewenyu99 · 2023-10-31T22:54:35Z

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

stnguyen90 · 2023-10-31T23:46:44Z

Unfortunately, I'm going to need to remove the hacktoberfest-accepted label as what's done so far doesn't actually implement anything.

SaketKaswa20 · 2023-11-01T02:35:00Z

No worries! It was great working with you all!

iSuslov · 2023-12-01T10:03:43Z

Well, kind of sad. Are there any plans to support it afterall? Oracle Cloud is undervalued for sure.

gewenyu99 · 2023-12-18T21:23:14Z

@iSuslov We'd still love a valid implementation of the Oracle Object Storage adapter. I just think the existing PR wasn't quite ready for merge.

We could also see a generic S3 adapter in the future, which would also solve the same issue.

TL;DR: We'd love to support it, this PR just wasn't ready for merge :)

SaketKaswa20 added 2 commits October 6, 2023 00:21

Added Oracle Object Storage adapter
1ff8f72

Added OracleObject Storage adapter
3c17bfa

SaketKaswa20 mentioned this pull request Oct 11, 2023
🗄️ Extend Appwrite Storage with Oracle Object Storage Adapter appwrite/appwrite#6415
Closed
7 tasks

stnguyen90 self-requested a review October 12, 2023 15:37

stnguyen90 suggested changes Oct 12, 2023
View reviewed changes

gewenyu99 requested a review from stnguyen90 October 18, 2023 03:28

stnguyen90 suggested changes Oct 19, 2023
View reviewed changes

phpunit tests done successfully
949b907

SaketKaswa20 requested a review from stnguyen90 October 24, 2023 13:09

stnguyen90 suggested changes Oct 24, 2023
View reviewed changes

gewenyu99 added the hacktoberfest-accepted label Oct 31, 2023

stnguyen90 removed the hacktoberfest-accepted label Oct 31, 2023

stnguyen90 closed this Nov 1, 2023

github-actionsBot mentioned this pull request Nov 1, 2023
PRs Opened in October 2023 appwrite/.github#93
Closed

github-actionsBot mentioned this pull request Dec 1, 2023
PRs Closed in November 2023 appwrite/.github#101
Closed


		const DEVICE_LINODE = 'linode';

		const DEVICE_ORACLEOBJECT = 'oracleobject';

	constDEVICE_ORACLEOBJECT = 'oracleobject';
	constDEVICE_ORACLE_OBJECT = 'oracleobject';

Uh oh!

Conversation

SaketKaswa20 commented Oct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

stnguyen90Oct 12, 2023

Choose a reason for hiding this comment

Uh oh!

stnguyen90Oct 12, 2023

Choose a reason for hiding this comment

Uh oh!

SaketKaswa20Oct 12, 2023

Choose a reason for hiding this comment

Uh oh!

SaketKaswa20 commented Oct 14, 2023

Uh oh!

gewenyu99 commented Oct 18, 2023

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

stnguyen90Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

stnguyen90Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

stnguyen90Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

stnguyen90Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

gewenyu99 commented Oct 31, 2023

Uh oh!

stnguyen90 commented Oct 31, 2023

Uh oh!

SaketKaswa20 commented Nov 1, 2023

Uh oh!

iSuslov commented Dec 1, 2023

Uh oh!

gewenyu99 commented Dec 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SaketKaswa20 commented Oct 5, 2023•
edited
Loading