Skip to content

Added support for CloudflareR2 Storage adaptar - #97

Closed
Tushar98644 wants to merge 5 commits into
utopia-php:mainfrom
Tushar98644:main
Closed

Added support for CloudflareR2 Storage adaptar#97
Tushar98644 wants to merge 5 commits into
utopia-php:mainfrom
Tushar98644:main

Conversation

@Tushar98644

@Tushar98644Tushar98644 commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown

fixesappwrite/appwrite#3352

Screenshots :

Screenshot 2023-10-19 at 3 35 33 PM

@Tushar98644Tushar98644 changed the title Added support for CloudfareR2 adaptarAdded support for CloudfareR2 Storage adaptarOct 19, 2023
@Tushar98644

Tushar98644 commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown
Author

@stnguyen90@gewenyu99 kindly review

@stnguyen90
stnguyen90 self-requested a review October 19, 2023 15:58
@bannu0snake

bannu0snake commented Oct 20, 2023

Copy link
Copy Markdown

hi @Tushar98644 , can you please let me know how did you setup php and testing env in your mac. any reference links ?

@Tushar98644

Tushar98644 commented Oct 20, 2023•
edited
Loading

Copy link
Copy Markdown
Author

hi @Tushar98644 , can you please let me know how did you setup php and testing env in your mac. any reference links ?

I just installed PHP and Composer,after installation you can add the project dependencies using composer install. You can have a look at the composer.json file , there you can find the scripts which used can be used to run the lining operations . For linting a file simply use composer format <file-path> and composer lint <file-path> to run the lining test

stnguyen90
stnguyen90 suggested changes Oct 24, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Please also make sure to run the test locally and attach a screenshot of the result.

Comment threadsrc/Storage/Device/CloudflareR2.php
Comment threadsrc/Storage/Device/CloudflareR2.php
public function __construct(string $root, string $accessKey, string $secretKey, string $bucket, string $region = self::APAC, string $acl = self::ACL_PRIVATE)
{
parent::__construct($root, $accessKey, $secretKey, $bucket, $region, $acl);
$this->headers['host'] = $bucket.'.'.'s3'.'.'.$region.'.cloudflarestorage.com';

@stnguyen90stnguyen90Oct 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any documentation on the host?

@docimindociminNov 16, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An S3 API URL looks like this:
https://accountid.r2.cloudflarestorage.com/bucketname

Where account id is your CF Account ID, like this:
https://905fa3fe223dcff4bf6b46911342bcfd.r2.cloudflarestorage.com/test

If you are using the EU Juristiction, you need to add .eu before the .r2, like this:
https://905fa3fe223dcff4bf6b46911342bcfd.eu.r2.cloudflarestorage.com/test

Comment threadsrc/Storage/Device/CloudflareR2.php Outdated
Comment threadsrc/Storage/Storage.php Outdated
Comment threadtests/Storage/Device/CloudfareR2Test.php
Comment thread.github/workflows/tests.yml
Comment threadtests/Storage/Device/CloudfareR2Test.php Outdated
@Tushar98644

Tushar98644 commented Oct 25, 2023

Copy link
Copy Markdown
Author

Great PR! 🤯 We left some comments during the review, please check them out.

Please also make sure to run the test locally and attach a screenshot of the result.

Do you mean the linting tests? I have attached a screenshot for the same in the pr description

@Tushar98644Tushar98644 changed the title Added support for CloudfareR2 Storage adaptarAdded support for CloudflareR2 Storage adaptarOct 26, 2023
@Tushar98644

Tushar98644 commented Oct 28, 2023

Copy link
Copy Markdown
Author

@stnguyen90 any updates ?

stnguyen90
stnguyen90 suggested changes Oct 31, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

Please also address https://github.com/utopia-php/storage/pull/97/files#r1370466673

Do you mean the linting tests? I have attached a screenshot for the same in the pr description

No, I mean actual tests. Something that confirms this code actually works with Cloudflare R2 storage.

Comment threadsrc/Storage/Device/CloudflareR2.php
Comment thread.github/workflows/tests.yml Outdated
Tushar98644and others added 2 commits October 31, 2023 21:40
@Tushar98644
Update CloudflareR2.php
fd7939b
@Tushar98644@stnguyen90
Update .github/workflows/tests.yml
13c7cdb
Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>
@Tushar98644

Tushar98644 commented Oct 31, 2023

Copy link
Copy Markdown
Author

Some minor changes.

Please also address https://github.com/utopia-php/storage/pull/97/files#r1370466673

Do you mean the linting tests? I have attached a screenshot for the same in the pr description

No, I mean actual tests. Something that confirms this code actually works with Cloudflare R2 storage.

Screenshot 2023-10-31 at 9 44 56 PM

I am having some issues with the card details and adding the r2 storage subscription to my account , would really appreciate it if you could test it from your side

@gewenyu99

gewenyu99 commented Oct 31, 2023

Copy link
Copy Markdown

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

@stnguyen90

stnguyen90 commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

I am having some issues with the card details and adding the r2 storage subscription to my account , would really appreciate it if you could test it from your side

How were you validating anything if you didn't have access to Cloudflare R2 storage?

stnguyen90
stnguyen90 suggested changes Nov 1, 2023
View reviewed changes
Comment threadsrc/Storage/Device/CloudflareR2.php
Comment on lines +9 to +16
/**
* Regions constants
* Reference: https://developers.cloudflare.com/durable-objects/platform/data-location/
*/

/**
* Regions constants
*/

@stnguyen90stnguyen90Oct 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consolidate

@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
@Tushar98644

Tushar98644 commented Nov 4, 2023

Copy link
Copy Markdown
Author

I am having some issues with the card details and adding the r2 storage subscription to my account , would really appreciate it if you could test it from your side

How were you validating anything if you didn't have access to Cloudflare R2 storage?

I wasn't , i just followed the guide for adding a new adapter

@docimin

docimin commented Nov 14, 2023

Copy link
Copy Markdown

Any update?

@stnguyen90

stnguyen90 commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

Closing as this doesn't actually work.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@docimindocimindocimin left review comments
@stnguyen90stnguyen90stnguyen90 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add support for Cloudflare R2 Storage

5 participants

@Tushar98644@bannu0snake@gewenyu99@stnguyen90@docimin