Uh oh!
There was an error while loading. Please reload this page.
install: report actual errors for special-file targets - #13645
install: report actual errors for special-file targets#13645Hashim1999164 wants to merge 1 commit into
Conversation
Let existing non-directory targets reach the normal replacement path so unlink failures report their real operating-system error.
Merging this PR will improve performance by 5.5%
|
| Mode | Benchmark | BASE | HEAD | Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | du_wide_tree[(5000, 500)] | 23 ms | 21.8 ms | +5.5% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Hashim1999164:fix/install-special-file-target (1622492) with main (eae5c43)
Footnotes
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
GNU testsuite comparison: |
Hashim1999164
commented
Jul 31, 2026
The failing CI jobs look unrelated to this change ( |
Summary
Fixes#9934
Validation
cargo fmt --checkcargo test --features install --no-default-features test_install_replaces_special_target(1 passed)cargo test --features install --no-default-features test_install::(98 passed)cargo clippy --features install --no-default-features --all-targets -- -D warnings