Skip to content

Rename the diffutils binary to diff, - #75

Closed
oSoMoN wants to merge 1 commit into
uutils:mainfrom
oSoMoN:several-binaries
Closed

Rename the diffutils binary to diff,#75
oSoMoN wants to merge 1 commit into
uutils:mainfrom
oSoMoN:several-binaries

Conversation

@oSoMoN

Copy link
Copy Markdown
Collaborator

in preparation for the future implementation of other binaries (cmp, sdiff and diff3)

in preparation for the future implementation of other binaries (cmp, sdiff and diff3)
@codecov

codecovBot commented Jun 4, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.06%. Comparing base (d362046) to head (9a7d8c8).
Report is 31 commits behind head on main.

Files with missing linesPatch %Lines
tests/integration.rs0.00%0 Missing and 16 partials ⚠️

❗ There is a different number of reports uploaded between BASE (d362046) and HEAD (9a7d8c8). Click for more details.

HEAD has 4 uploads less than BASE
FlagBASE (d362046)HEAD (9a7d8c8)
ubuntu_latest21
macos_latest20
windows_latest21
Additional details and impacted files
@@ Coverage Diff @@## main #75 +/- ##
==========================================
- Coverage 82.48% 75.06% -7.42% 
==========================================
Files 10 10 Lines 2935 2876 -59 Branches 744 744 ==========================================
- Hits 2421 2159 -262 
Misses 495 495 - Partials 19 222 +203 
FlagCoverage Δ
macos_latest?
ubuntu_latest75.45% <0.00%> (ø)
windows_latest15.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre

Copy link
Copy Markdown
Collaborator

what is your plan here? Create new binaries ?

What about doing the same as coreutils ? One main binaries (or individual programs)
and if you do ln -s diffutils diff or ln -s diffutils cmp, it will change the behavior of the command.

@oSoMoN

Copy link
Copy Markdown
CollaboratorAuthor

I was thinking of individual binaries, but I must admit I didn't look at how it's done for coreutils, and I suppose it makes sense to do something similar. I'll take a look later, in the meantime I'm leaving this PR open.

@oSoMoN
oSoMoN marked this pull request as draft June 4, 2024 18:28
@sylvestre

Copy link
Copy Markdown
Collaborator

the main adv is the size of the binaries as Rust bins have a tendency to be bigger than C :)

@oSoMoN

Copy link
Copy Markdown
CollaboratorAuthor

Closing, as this is definitely being obsoleted by Gustavo's work in #88.

@oSoMoNoSoMoN closed this Sep 26, 2024
@oSoMoN
oSoMoN deleted the several-binaries branch September 26, 2024 20:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@oSoMoN@sylvestre