Uh oh!
There was an error while loading. Please reload this page.
w: don't fail when tty device is missing - #719
Open
Franklin-Qi wants to merge 1 commit into
Open
Conversation
- Treat missing or unreadable `/dev/<tty>` as zero idle time instead of exiting with an error - Add unit test for missing tty handling Closes: uutils#718
sylvestre
commented
Jun 16, 2026
Contributor
can we also get a test in https://github.com/uutils/procps/blob/main/tests/by-util/test_w.rs ? thanks |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #719 +/- ##
==========================================
- Coverage 19.19% 19.18% -0.01%
==========================================
Files 68 68 Lines 10158 10162 +4 Branches 546 549 +3 ==========================================
Hits 1950 1950 - Misses 8208 8212 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Franklin-Qi
commented
Jun 18, 2026
ContributorAuthor
@sylvestre Thank you for the review; I will add test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/dev/<tty>as zero idle time instead of exiting with an errorCloses: #718