Uh oh!
There was an error while loading. Please reload this page.
Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions" - #195
Closed
gahaas wants to merge 1 commit into
Closed
Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions"#195gahaas wants to merge 1 commit into
gahaas wants to merge 1 commit into
Conversation
isheludko
self-requested a review
June 24, 2024 09:14
isheludko
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #192
This PR caused failing tests. Preparation is needed in V8 to allow exceptions to be thrown in fast API callbacks called from the wasm wrapper.