Uh oh!
There was an error while loading. Please reload this page.
Renaming main files and creating modules for the med-diagnosis pattern - #310
Renaming main files and creating modules for the med-diagnosis pattern#310abhatt-rh wants to merge 7 commits into
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abhatt-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
aa8cb9b to
8ae400eCompareThis is an automated message: You can preview this docs PR at http://310.docs-pr.validatedpatterns.io |
404f63e to
f6bb3d0Compareabhatt-rh
commented
Oct 16, 2023
Hi @danmacpherson PTAL. Thanks! |
danmacpherson
left a comment
There was a problem hiding this comment.
Hi Avani,
A few minor suggestions, and a few other things:
- I couldn't seem to comment on the troubleshooting section since it looks like it's largely unchanged and so I can't leave feedback on any diff. This might need to be rechecked as I noticed a few things that needed some style and consistency.
- Likewise I think there's something odd with the title levels in the Troubleshooting section.
- There are a fair few videos/animations in this content. I wonder if we can include these things in our enterprise docs. Something to check out.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| $ git push origin my-branch | ||
| ---- | ||
| . To deploy the pattern, you can use the link:/infrastructure/using-validated-pattern-operator/[{validated-patterns-op}]. If you use the Operator to deploy the pattern, skip to the _Verification_ section of this procedure. |
There was a problem hiding this comment.
This step might be better suited for the Deploying the Medical Diagnosis pattern section. E.g. say you can deploy the pattern either with the operator or with the command line
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7d652e3 to
2b603dfCompareabhatt-rh
commented
Nov 23, 2023
Not merging this yet since I have a discussion open to understand why the htmltest fails for files that are renamed |
@abhatt-rh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
commented
Sep 1, 2025
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/TELCODOCS-1193
Preview: https://310.docs-pr.acksyn.org/patterns/medical-diagnosis/