Skip to content

Renaming main files and creating modules for the med-diagnosis pattern - #310

Open
abhatt-rh wants to merge 7 commits into
validatedpatterns:mainfrom
abhatt-rh:1193-modular
Open

Renaming main files and creating modules for the med-diagnosis pattern#310
abhatt-rh wants to merge 7 commits into
validatedpatterns:mainfrom
abhatt-rh:1193-modular

Conversation

@abhatt-rh

@abhatt-rhabhatt-rh commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhatt-rh

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhatt-rh
abhatt-rhforce-pushed the 1193-modular branch 2 times, most recently from aa8cb9b to 8ae400eCompareOctober 9, 2023 19:19
@abhatt-rhabhatt-rh changed the title Renaming main files for the med-diagnosis pattern for modular docsRenaming main files and creating modules for the med-diagnosis patternOct 9, 2023
@mbaldessari

mbaldessari commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

This is an automated message:

You can preview this docs PR at http://310.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

@abhatt-rh
abhatt-rhforce-pushed the 1193-modular branch 2 times, most recently from 404f63e to f6bb3d0CompareOctober 10, 2023 16:52
@abhatt-rh

Copy link
Copy Markdown
CollaboratorAuthor

Hi @danmacpherson PTAL. Thanks!

@danmacphersondanmacpherson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Avani,

A few minor suggestions, and a few other things:

  • I couldn't seem to comment on the troubleshooting section since it looks like it's largely unchanged and so I can't leave feedback on any diff. This might need to be rechecked as I noticed a few things that needed some style and consistency.
  • Likewise I think there's something odd with the title levels in the Troubleshooting section.
  • There are a fair few videos/animations in this content. I wonder if we can include these things in our enterprise docs. Something to check out.

Comment threadmodules/med-about-medical-diagnosis.adoc Outdated
Comment threadmodules/med-setup-aws-s3-bucket-with-utilities.adoc Outdated
Comment threadmodules/med-preparing-for-deployment.adoc Outdated
Comment threadmodules/med-preparing-for-deployment.adoc
$ git push origin my-branch
----

. To deploy the pattern, you can use the link:/infrastructure/using-validated-pattern-operator/[{validated-patterns-op}]. If you use the Operator to deploy the pattern, skip to the _Verification_ section of this procedure.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step might be better suited for the Deploying the Medical Diagnosis pattern section. E.g. say you can deploy the pattern either with the operator or with the command line

Comment threadmodules/med-troubleshooting-deployment.adoc
Comment threadmodules/med-about-customizing-pattern.adoc Outdated
Comment threadmodules/med-about-customizing-pattern.adoc Outdated
Comment threadmodules/med-about-customizing-pattern.adoc Outdated
Comment threadmodules/med-about-customizing-pattern.adoc Outdated
@abhatt-rh
abhatt-rhforce-pushed the 1193-modular branch 2 times, most recently from 7d652e3 to 2b603dfCompareNovember 17, 2023 19:59
@abhatt-rh

Copy link
Copy Markdown
CollaboratorAuthor

Not merging this yet since I have a discussion open to understand why the htmltest fails for files that are renamed

@openshift-ci

Copy link
Copy Markdown
Contributor

@abhatt-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/build-previewd14ae64linktrue/test build-preview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhatt-rh@mbaldessari@openshift-merge-robot@danmacpherson