Uh oh!
There was an error while loading. Please reload this page.
Add Vietnamese locale to isAlpha and isAlphaNumeric function - #1189
Add Vietnamese locale to isAlpha and isAlphaNumeric function#1189nguyenngo99 wants to merge 3 commits into
Conversation
tux-tn
left a comment
There was a problem hiding this comment.
Great job, you may also need to add the new locale to README.md docs file
nguyenngo99
commented
Nov 9, 2019
Okey, I updated |
profnandaa
left a comment
There was a problem hiding this comment.
Can you add the regex for that or alias?
nguyenngo99
commented
Nov 12, 2019
I'm newbie so I'm don't understand what is alias. Could you explain it? |
profnandaa
commented
Mar 22, 2020
@damdauvaotran -- my bad, forget what I said. I think I'd confused your changes with something else. Please see my new comments. And sorry for my delay on getting to this :( |
profnandaa
left a comment
There was a problem hiding this comment.
Other than that, everything else looks good to me. Just make the change, fix the m/c and we should be good to go.
Thanks for your contrib! 🎉
| 'en-ZA': /^(\+?27|0)\d{9}$/, | ||
| 'en-ZM': /^(\+?26)?09[567]\d{7}$/, | ||
| 'es-CL': /^(\+?56|0)[2-9]\d{1}\d{7}$/, | ||
| 'es-EC': /^(\+?593|0)[2-7,9]\d{7,8}$/, |
There was a problem hiding this comment.
Was this part of this PR too? If so, add some tests too.
profnandaa
commented
Jun 13, 2020
ping @damdauvaotran |
rubiin
commented
Jul 2, 2020
@profnandaa this can be closed |
Add Vietnamese locale to isAlpha and isAlphaNumeric function and test