Skip to content

Test against valid and invalid US TIN prefixes - #1408

Merged
profnandaa merged 1 commit into
validatorjs:masterfrom
dspinellis:test-us-TIN-prefix
Aug 19, 2020
Merged

Test against valid and invalid US TIN prefixes#1408
profnandaa merged 1 commit into
validatorjs:masterfrom
dspinellis:test-us-TIN-prefix

Conversation

@dspinellis

@dspinellisdspinellis commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

The existing isTaxId validation tests only checked the format,
while the validation code also tests for valid (US campus)
prefixes. The added tests, check that the prefix validations
actually work.

This has been done as a safety measure for the code's refactoring and the support of another locale. I will issue these in further PRs.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

The existing isTaxId validation tests only checked the format,
while the validation code also tests for valid (US campus)
prefixes. The added tests, check that the prefix validations
actually work.
@codecov

codecovBot commented Aug 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #1408 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 95 95 Lines 1248 1248 =========================================
Hits 1248 1248 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed86b0a...a605fae. Read the comment docs.

@profnandaa
profnandaa merged commit db0a402 into validatorjs:masterAug 19, 2020
@profnandaa

Copy link
Copy Markdown
Member

Thanks for your contrib! 🎉

@profnandaaprofnandaa mentioned this pull request Sep 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dspinellis@profnandaa