Skip to content

Fix, fa, fa-IR, fa-AF based on cldr - #1411

Merged
profnandaa merged 2 commits into
validatorjs:masterfrom
mhf-ir:master
Aug 19, 2020
Merged

Fix, fa, fa-IR, fa-AF based on cldr#1411
profnandaa merged 2 commits into
validatorjs:masterfrom
mhf-ir:master

Conversation

@mhf-ir

Copy link
Copy Markdown
Contributor

Cldr process script
https://gist.github.com/mhf-ir/04a6fc43c8f931b0d0cfa1dc02730c1b

Characters:
https://github.com/unicode-cldr/cldr-misc-modern/blob/master/main/fa/characters.json#L10
Default country for fa is IR
https://github.com/unicode-cldr/cldr-core/blob/master/defaultContent.json#L52

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

codecovBot commented Aug 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1411 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1411 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 95 95 Lines 1248 1254 +6 =========================================
+ Hits 1248 1254 +6 
Impacted FilesCoverage Δ
src/lib/alpha.js100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed86b0a...65db5ec. Read the comment docs.

@profnandaaprofnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contrib! 🎉
/cc. @tux-tn@ezkemboi

@tux-tntux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
great work @mhf-ir 🎉

@mikeerickson

Copy link
Copy Markdown

Thanks for all the efforts on this, I will get it reviewed as soon as possible.

@profnandaa
profnandaa merged commit 28f7f65 into validatorjs:masterAug 19, 2020
@profnandaaprofnandaa mentioned this pull request Sep 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mhf-ir@mikeerickson@profnandaa@tux-tn