Skip to content

fix(isUrl): add proper validation for emails - #1425

Merged
profnandaa merged 1 commit into
validatorjs:masterfrom
heanzyzabala:bugfix/isBase64-update-regex
Aug 31, 2020
Merged

fix(isUrl): add proper validation for emails#1425
profnandaa merged 1 commit into
validatorjs:masterfrom
heanzyzabala:bugfix/isBase64-update-regex

Conversation

@heanzyzabala

Copy link
Copy Markdown
Contributor

See: #1375

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

codecovBot commented Aug 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1425 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1425 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 95 95 Lines 1254 1254 =========================================
Hits 1254 1254 
Impacted FilesCoverage Δ
src/lib/isURL.js100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec9426...7a0c524. Read the comment docs.

@profnandaaprofnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@heanzyzabala@profnandaa