Gitignore by rubiin · Pull Request #1450 · validatorjs/validator.js

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin · 2020-09-30T13:54:16Z

Added few folders that contains generated code. Thus the git status does not get messy

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-09-30T13:57:53Z

Codecov Report

Merging #1450 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1450 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 95 95 Lines 1268 1270 +2 =======================================
+ Hits 1267 1269 +2 
Misses 1 1

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3d2...fc66787. Read the comment docs.

rubiin · 2020-09-30T13:59:37Z

@profnandaa check this only after my previous pr

ezkemboi · 2020-09-30T17:01:42Z

 .nyc_output
 package-lock.json
 yarn.lock
+es


What is your opinion in ignoring the generated files @profnandaa and @tux-tn?

ezkemboi · 2020-09-30T17:02:30Z

 **isDivisibleBy(str, number)** | check if the string is a number that's divisible by another.
 **isEAN(str)** | check if the string is an EAN (European Article Number).
-**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail.
+**isEmail(str [, options])** | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '' }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` recieves a string,then the validator will reject emails that include any of the characters in the string, in the name part.


These are the same files changed as in #1449

ezkemboi · 2020-09-30T17:03:09Z


 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }

+import merge from './util/merge';


There are many changes here that are the same as in #1449.
Please remove them

rubiin · 2020-09-30T17:33:58Z

i am closing this as and will do another pr

profnandaa · 2020-10-04T16:29:03Z

Remember to link it to the issue once done.

We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

rubiin added 2 commits September 30, 2020 18:31

added email character blacklist
cd2ae36

Update .gitignore
fc66787

rubiin mentioned this pull request Sep 30, 2020
Generated files should be gitignored. #1438
Closed

ezkemboi reviewed Sep 30, 2020
View reviewed changes

ezkemboi requested changes Sep 30, 2020
View reviewed changes

rubiin closed this Sep 30, 2020

rubiin deleted the gitignore branch September 30, 2020 17:43

profnandaa added a commit that referenced this pull request Nov 24, 2020
chore: update gitignore
f848177
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

profnandaa mentioned this pull request Nov 24, 2020
chore: update gitignore #1525
Closed

profnandaa added a commit that referenced this pull request Nov 24, 2020
chore: update gitignore
aefaf35
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

profnandaa added a commit that referenced this pull request Nov 24, 2020
chore: update gitignore
8ebbe46
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

profnandaa mentioned this pull request Nov 24, 2020
chore: update gitignore #1526
Closed

profnandaa added a commit that referenced this pull request Nov 24, 2020
chore: update gitignore
a505bc0
We are removing validator.js and validator.min.js since they are among the top files that cause unnecessary conflicts, yet they are dependent on the build system. this is a follow up of #1450

profnandaa mentioned this pull request Nov 24, 2020
chore: update gitignore #1527
Merged