Add Czech license plates by filiptronicek · Pull Request #1565 · validatorjs/validator.js

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek · 2020-12-30T21:51:26Z

I have added Czech license plates with regards to all the possible cases I found. RegExr with tests

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable) - I think I need help with this one

codecov · 2020-12-30T21:58:37Z

Codecov Report

Merging #1565 (2322e06) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1565 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 1854 1855 +1 =========================================
+ Hits 1854 1855 +1

Impacted Files	Coverage Δ
src/lib/isLicensePlate.js	`100.00% <100.00%> (ø)`
src/lib/isPassportNumber.js	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...2322e06. Read the comment docs.

profnandaa

Looks good, however, could add a few test cases?

filiptronicek · 2021-02-15T10:02:02Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

MoltenCoffee · 2021-05-11T06:43:48Z

@profnandaa yes, totally agreed, but as I mentioned, I am not really comfortable in writing tests here yet, any guide to get me started?

This should get you started:

test({validator: 'isLicensePlate',args: ['cs-CZ'],valid: ['valid-plate1','valid-plate2'],invalid: ['','invalidlicenseplate','A1-B2-C3','ABC-1-EF',],});

Edit and add to /test/validators.js, here

fedeci · 2021-05-11T11:31:03Z


 const validators = {
+ 'cs-CZ': str =>
+ /^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),


Suggested change
/^(([ABCDEFHKIJKLMNPRSTUVXYZ]|[0-9])-?){5,8}$/.test(str),
/^[0-9]([A-Z][0-9]{5}|[A-Z]{2}[0-9]{4})$/.test(str),
nit: we can increase accuracy in this way.
Passing examples:
0A189290AB1892
This regex does not take into account custom license plates and we have to check it separately.

This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.

According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔

I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
Today's marks contain five to seven characters, depending on the vehicle type (numbers and letters without accents, except for G, O, Q, W, which could be confused with C, V, and the number 0 or the number 6).
This means, that this applies to all license plates, not just custom ones.

rubiin · 2021-07-05T15:07:30Z

@profnandaa looks stale , lets get it merged if author is still available or I could add in few tests with the new PR

filiptronicek · 2021-07-05T16:31:56Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

rubiin · 2021-07-05T17:16:17Z

Hi, @rubiin, I am still available for any changes or tests to be made. I think there is still an unresolved discussion about whether to handle custom license plates separately or not from the review by @fedeci. If this gets resolved we should be ready to merge. (at least I think so)

Yes please add more tests as said by @profnandaa so we could merge it. This is to limit stale PRs

filiptronicek · 2021-07-06T20:36:39Z

@rubiin added those tests!

profnandaa

Thanks for your contribution! 🎉

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

filiptronicek added 3 commits December 30, 2020 21:42

Add Czech license plates to the RegEx mix
c804485

Reorder list
c420de2

Update README
b57bfb2

profnandaa reviewed Feb 15, 2021
View reviewed changes

profnandaa added 🎉 first-pr needs-tests labels Feb 15, 2021

filiptronicek added 2 commits May 11, 2021 09:27

Add tests
e0decd0

Merge branch 'master' into czech-license-plates
37dc1e8

filiptronicek requested a review from profnandaa May 11, 2021 10:18

fedeci reviewed May 11, 2021
View reviewed changes

Remove trailing space
6d4b269

profnandaa added 🕑 to-be-reviewed and removed needs-tests labels May 24, 2021

Add more tests
2322e06

profnandaa approved these changes Jul 16, 2021
View reviewed changes

profnandaa merged commit c87956a into validatorjs:masterJul 16, 2021

profnandaa mentioned this pull request Oct 31, 2021
release staging: November 2021 release (13.7.0) #1853
Closed

	/^(([ABCDEFHKIJKLMNPRSTUVXYZ]\|[0-9])-?){5,8}$/.test(str),
	/^[0-9]([A-Z][0-9]{5}\|[A-Z]{2}[0-9]{4})$/.test(str),

Uh oh!

Uh oh!

Conversation

filiptronicek commented Dec 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecovBot commented Dec 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

filiptronicek commented Feb 15, 2021

Uh oh!

MoltenCoffee commented May 11, 2021

Uh oh!

fedeciMay 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubiin commented Jul 5, 2021

Uh oh!

filiptronicek commented Jul 5, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rubiin commented Jul 5, 2021

Uh oh!

filiptronicek commented Jul 6, 2021

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

filiptronicek commented Dec 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecovBot commented Dec 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

filiptronicek commented Feb 15, 2021

Uh oh!

MoltenCoffee commented May 11, 2021

Uh oh!

fedeciMay 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubiin commented Jul 5, 2021

Uh oh!

filiptronicek commented Jul 5, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

filiptronicek commented Dec 30, 2020•
edited
Loading

codecovBot commented Dec 30, 2020•
edited
Loading

fedeciMay 11, 2021•
edited
Loading

filiptronicek commented Jul 5, 2021•
edited
Loading

filiptronicek commented Dec 30, 2020•
edited
Loading

codecovBot commented Dec 30, 2020•
edited
Loading

fedeciMay 11, 2021•
edited
Loading

filiptronicek commented Jul 5, 2021•
edited
Loading

filiptronicek commented Dec 30, 2020•
edited
Loading

codecovBot commented Dec 30, 2020•
edited
Loading

fedeciMay 11, 2021•
edited
Loading

filiptronicek commented Jul 5, 2021•
edited
Loading