feat(isFQDN): add allow_wildcard option

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.

[fasenderos]

Added the allow_wildcard option for isFQDN. Now the validator can allow domain starting with *. (e.g. *.example.com or *.shop.example.com).
Fixes#1646

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1647 (b2fff10) into master (a31c116) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1647 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1845 +2 =========================================
+ Hits 1843 1845 +2 

Impacted Files	Coverage Δ
src/lib/isFQDN.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c116...b2fff10. Read the comment docs.

[profnandaa]

Not quite sure about the validity of this one; will we violating FQDN in principle? Can we leave this to the user to clean out the *. before sending in the rest to isFQDN?

[fasenderos]

@profnandaa I’m using validator.js on backend (NestJs with class-validator that hunder the hood use validator.js) to validate DTO on Rest API. So in my case it’s perfectly valid to let client send domain with wildcard. Alternatively I should use some ugly regex. Even more wildcard FQDN is commonly used e.g. on SSL certificate and Firewall, and i think it can be helpful for such frontend application. I hope this PR will be merged soon.

[profnandaa]

@tux-tn -- please have a look and advise.

[fasenderos]

@tux-tn@profnandaa any updates here? Would love to see this!

[fasenderos]

@profnandaa and @ezkemboi please ignore the reviews requests, were made by mistake. Sorry

[profnandaa]

@tux-tn -- could you please have a look at this?

[cowboy-bebug]

Why is it difficult to remove this specific pattern?

"*.example.com".replace(/^\*\./,"")

I hope this doesn't introduce any potential exploits 🤞

[fasenderos]

My intent here is not to sanitize the input, but to validate the input client side. Sanitization eventually comes as a backend stuff

[tux-tn]

LGTM 🎉
Sorry for the late review 😅

[profnandaa]

Sorry for the delay, will be getting this in. I'm staging the release this weekend for final check off by the maintainers on Monday/Tuesday and we make the release.