fix(isEmail): replace all dots in gmail length validation by DasDingGehtNicht · Pull Request #1718 · validatorjs/validator.js

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉

DasDingGehtNicht · 2021-08-30T14:29:30Z

The gmail domain specific validator checks the length of the username part and replaces dots as they don't count against the limit. But the replace function only replaced the first dot. Fixed by using regex with g switch.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-08-30T14:30:55Z

Codecov Report

Merging #1718 (89f02c2) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1718 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 101 101 Lines 2005 2005 Branches 452 452 =========================================
Hits 2005 2005

Impacted Files	Coverage Δ
src/lib/isEmail.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...89f02c2. Read the comment docs.

fedeci

Could you add test cases?

DasDingGehtNicht · 2021-08-30T15:15:48Z

Could you add test cases?

modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

tux-tn

LGTM 🎉
Nice catch!

fedeci · 2021-08-30T20:30:38Z

 'test|123@m端ller.com',
 'test123+ext@gmail.com',
- 'some.name.midd.leNa.me+extension@GoogleMail.com',
+ 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',


Why it was passing the test before? Is the GoogleMail domain part of gmail?

Max length is supposed to be 30 characters without the dots and the email alias (any string after the + character) . Even after removing only one dot the old string length was less than 30

03-65 · 2021-09-01T23:41:48Z

I have no idea how to code

03-65 · 2021-09-01T23:44:22Z

Could you add test cases?
modified existing test case.
test case: 'some.name.midd.leNa.me.and.locality+extension@GoogleMail.com',
pre-fix: invalid (somename.midd.leNa.me.and.locality = 35 chars)
post-fix: valid (somenamemiddleNameandlocality = 29 chars)

I don't know what you mean and I'm unable to Upload files it tells me

03-65 · 2021-09-09T07:19:48Z

Thank you

profnandaa

Good catch, thanks! 🎉