refactor: run scripts in parallel for build and clean

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn

[sachinraja]

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1747 (6179d41) into master (c899b31) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1747 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2015 2015 Branches 454 454 =========================================
Hits 2015 2015 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...6179d41. Read the comment docs.

[fedeci]

Isn't the same result achieved using a single & and without having to add another dep?

Suggested change

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

[sachinraja]

That doesn't work on Windows (with cmd.exe)

[fedeci]

Damn, shitty cmd🙃

[tux-tn]

LGTM 🎉 ! Thank you for the PR @sachinraja

[sachinraja]

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

[tux-tn]

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

[profnandaa]

Thanks @sachinraja for your PR! 🎉

[sachinraja]

Got it, thanks for explaining @tux-tn