Uh oh!
There was an error while loading. Please reload this page.
feat(isCpf): Add Brazilian CPF validation - #1755
Conversation
Codecov Report
@@ Coverage Diff @@## master #1755 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 102 103 +1 Lines 2029 2053 +24 Branches 457 462 +5 ===========================================
+ Hits 2029 2051 +22 - Misses 0 1 +1 - Partials 0 1 +1
Continue to review full report at Codecov.
|
fedeci
left a comment
There was a problem hiding this comment.
I think this is a sort of VAT number, right?
ygorazambuja
commented
Oct 3, 2021
yes, sort of. |
fedeci
commented
Oct 3, 2021
Because I think it would be better to add it to isVAT, then. |
ygorazambuja
commented
Oct 3, 2021
its not simple as VAT, CPF Validation require some math calculation, and works only for Brazil. |
fedeci
commented
Oct 3, 2021
Of course it is exclusive to brazil, also in Italy it is called IVA instead of VAT, but the meaning is practically the same. I'd suggest you to implement it in the |
ygorazambuja
commented
Oct 3, 2021
It will lose its meaning, vat is tax identification number, cpf is registration of individuals. No Brazilian will search for VAT Validation, they will search for CPF Validation. I myself didn't know about the existence of VAT until this PR |
fedeci
commented
Oct 3, 2021
Let's ear maintainer's opinions :) |
ygorazambuja
commented
Oct 3, 2021
sure :) |
tux-tn
commented
Oct 4, 2021
Hello @ygorazambuja and thank you for your PR! |
fedeci
commented
Oct 4, 2021
What is the difference between isTaxID and isVAT? |
Honestly i don't know, in my country Tax ID and VAT number are the same thing (it's called tax registration number) but it looks like many countries have two separated identifiers. May be we need to dig into this and merge the two validators! |
fedeci
commented
Oct 4, 2021
In Italy they are the same number. Probably it is different just in GB? |
ygorazambuja
commented
Oct 4, 2021
it's like that, but I still don't agree with the name of the method, it makes it difficult to adhere to the library (in relation to this specific method of course). I will close the PR so, thanks for the feedbacks. |
feat(isCpf)
Add Brazilian CPF Validation (Cadastro de Pessoas Fisicas)
Widely used in programs that use personal registration