Refactoring: Splitted test/validators.js to multiple subfiles

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?

[Marcholio]

Splitted the huge test/validators.js file into multiple subfiles, one per validator function. This makes it easier to read the test cases and maintain them as well. Did not change any test content, only moved existing cases to new files.

This will naturally cause conflicts with currently open PRs, but they should be easy to tackle, once this is mered.

Fixes: #1791

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Merging #1793 (26eb5c5) into master (f055c11) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2072 2072 Branches 472 472 =========================================
Hits 2072 2072 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...26eb5c5. Read the comment docs.

[tux-tn]

Awesome work @Marcholio ! Thank you for your efforts ❤️

cc @ezkemboi@profnandaa any feedback about this? it will be easier to handle tests in the future but the only issue is that we will have planty of merge conflicts for the already open PRs.

[ezkemboi]

Yes, we will have merge conflicts, but, I like the idea of splitting tests.

[Marcholio]

Updated the PR with latest updates from master. This should probably be merged soon to avoid further conflicts.

[profnandaa]

@Marcholio -- thanks for this. Kindly let's hold off this one first until we are done with the backlog for this next release and then this can be a good one to reconsider during the down-time.

[tux-tn]

@Marcholio since we are in the process of merging many pending PRs i suggest you wait for all of them to be merged before fixing conflicts. (Thank you again for your efforts 🎉 )

[tux-tn]

@Marcholio Most of the ready to land PRs have been merged. You can go ahead and fix conflicts/add missing tests.
Thank you !

[Marcholio]

@tux-tn Rebased & solved the conflicts now

[tux-tn]

Thank you @Marcholio !

@profnandaa Can we merge this PR?

[WikiRik]

@rubiin Do you think we can rebase this and merge it soon?