fix: german phone numbers by reverting #1391 - #1868

Merged
profnandaa merged 2 commits into
validatorjs:masterfrom
thomaschaaf:revert-1391
Nov 17, 2021
Merged

fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom
thomaschaaf:revert-1391

Conversation

@thomaschaaf

@thomaschaafthomaschaaf commented Nov 15, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

reverting #1391

thomaschaaf
thomaschaaf commented Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
'015412345678',
],
invalid: [
'+4930405044550',

@thomaschaafthomaschaafNov 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17

thomaschaaf
thomaschaaf commented Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
'17012345678',
'+4912345678910',
'+49015123456789',
'015345678910',

@thomaschaafthomaschaafNov 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.

@thomaschaafthomaschaaf changed the title revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn requested changes Nov 15, 2021
View reviewed changes

@tux-tntux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !
The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅

Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX

@tux-tntux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Nov 15, 2021
tux-tn
tux-tn approved these changes Nov 15, 2021
View reviewed changes

@tux-tntux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉

@tux-tntux-tn added ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Nov 15, 2021
@codecov

codecovBot commented Nov 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1868 (a107753) into master (47ee5ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.

@profnandaa
profnandaa merged commit 9c12b4c into validatorjs:masterNov 17, 2021
@profnandaaprofnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicenterntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembramChinmoyHembram mentioned this pull request May 25, 2024
Open
@wambugucoderwambugucoder mentioned this pull request May 30, 2024
Open
@rntvicenterntvicente mentioned this pull request May 30, 2024
Open
@DefenderKDefenderK mentioned this pull request May 30, 2024
Closed
@ChinmoyHembramChinmoyHembram mentioned this pull request May 30, 2024
Open
@ceconcarlsenceconcarlsen mentioned this pull request May 31, 2024
Open
@sumandas0sumandas0 mentioned this pull request May 31, 2024
Open
This was referenced Jun 3, 2024
Closed
Closed
@DefenderKDefenderK mentioned this pull request Jun 7, 2024
Closed
@IT21275210IT21275210 mentioned this pull request Jun 8, 2024
Open
@snyk-iosnyk-ioBot mentioned this pull request Jun 10, 2024
Closed
@florinMiroflorinMiro mentioned this pull request Jun 11, 2024
Closed
@snyk-iosnyk-ioBot mentioned this pull request Jun 11, 2024
Closed
This was referenced Jun 12, 2024
Closed
Closed
@snyk-iosnyk-ioBot mentioned this pull request Jun 13, 2024
Closed
@DefenderKDefenderK mentioned this pull request Jun 13, 2024
Closed
This was referenced Jun 14, 2024
Closed
Closed
@DefenderKDefenderK mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 20, 2024
Closed
Closed
@snyk-iosnyk-ioBot mentioned this pull request Jun 28, 2024
Closed
This was referenced Jul 10, 2024
Closed
Closed
Closed
@rm-neilsondesarm-neilsondesa mentioned this pull request Jul 16, 2024
Open
@snyk-iosnyk-ioBot mentioned this pull request Jul 18, 2024
Closed
@DefenderKDefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
@luizhpluizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@KOTTAGENVHKOTTAGENVH mentioned this pull request Sep 27, 2024
Open
@DefenderKDefenderK mentioned this pull request Oct 30, 2024
Closed
@fossabotfossabotBot mentioned this pull request Oct 28, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees

No one assigned

Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix: german phone numbers by reverting #1391 - #1868
Merged
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Nov 17, 2021
Merged
fix: german phone numbers by reverting #1391#1868
profnandaa merged 2 commits into
validatorjs:masterfrom 
thomaschaaf:revert-1391
Conversation
@thomaschaaf
@thomaschaafthomaschaaf
commented
Nov 15, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
reverting #1391
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '015412345678',
 ],
 invalid: [
 '+4930405044550',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
thomaschaaf
thomaschaaf
commented
Nov 15, 2021
View reviewed changes
Comment threadtest/validators.js
 '17012345678',
 '+4912345678910',
 '+49015123456789',
 '015345678910',
@thomaschaafthomaschaafNov 15, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
@thomaschaafthomaschaaf
changed the title
revert #1391fix: german phone numbers by reverting #1391Nov 15, 2021
tux-tn
tux-tn
requested changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
@tux-tntux-tn
added

🎉 first-pr

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
tux-tn
tux-tn
approved these changes
Nov 15, 2021
View reviewed changes
@tux-tntux-tn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
@tux-tntux-tn
added

ready-to-land
For PRs that are reviewed and ready to be landed
and removed

🧹 needs-update
For PRs that need to be updated before landing
labels
Nov 15, 2021
@codecov
codecovBot
commented
Nov 15, 2021

Copy link


Copy Markdown

Codecov Report
Merging #1868 (a107753) into master (47ee5ad) will not change coverage.

The diff coverage is n/a.
Impacted file tree graph
@@ Coverage Diff @@## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 102 102 Lines 2059 2059 Branches 464 464 =========================================
Hits 2059 2059 
Impacted FilesCoverage Δ
src/lib/isMobilePhone.js100.00% <ø> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.
@profnandaa
profnandaa
merged commit 9c12b4c
into
validatorjs:masterNov 17, 2021
@profnandaaprofnandaa
mentioned this pull request
Feb 2, 2023
 Closed

@rntvicenterntvicente
mentioned this pull request
May 24, 2024
 Open

@sahilpawar58sahilpawar58
mentioned this pull request
May 25, 2024
 Open

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 25, 2024
 Open

@wambugucoderwambugucoder
mentioned this pull request
May 30, 2024
 Open

@rntvicenterntvicente
mentioned this pull request
May 30, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
May 30, 2024
 Closed

@ChinmoyHembramChinmoyHembram
mentioned this pull request
May 30, 2024
 Open

@ceconcarlsenceconcarlsen
mentioned this pull request
May 31, 2024
 Open

@sumandas0sumandas0
mentioned this pull request
May 31, 2024
 Open


This was referenced Jun 3, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 7, 2024
 Closed

@IT21275210IT21275210
mentioned this pull request
Jun 8, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 10, 2024
 Closed

@florinMiroflorinMiro
mentioned this pull request
Jun 11, 2024
 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 11, 2024
 Closed


This was referenced Jun 12, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 13, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 13, 2024
 Closed


This was referenced Jun 14, 2024
 Closed

 Closed

@DefenderKDefenderK
mentioned this pull request
Jun 14, 2024
 Closed


This was referenced Jun 20, 2024
 Closed

 Closed

@snyk-iosnyk-ioBot
mentioned this pull request
Jun 28, 2024
 Closed


This was referenced Jul 10, 2024
 Closed

 Closed

 Closed

@rm-neilsondesarm-neilsondesa
mentioned this pull request
Jul 16, 2024
 Open

@snyk-iosnyk-ioBot
mentioned this pull request
Jul 18, 2024
 Closed

@DefenderKDefenderK
mentioned this pull request
Jul 18, 2024
 Closed


This was referenced Jul 19, 2024
 Closed

 Closed

 Closed

@luizhpluizhp
mentioned this pull request
Aug 21, 2024
 Open


This was referenced Aug 30, 2024
 Open

 Open

@KOTTAGENVHKOTTAGENVH
mentioned this pull request
Sep 27, 2024
 Open

@DefenderKDefenderK
mentioned this pull request
Oct 30, 2024
 Closed

@fossabotfossabotBot
mentioned this pull request
Oct 28, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes
@tux-tntux-tntux-tn approved these changes

Assignees


No one assigned


Labels

🎉 first-prready-to-landFor PRs that are reviewed and ready to be landed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@thomaschaaf@profnandaa@tux-tn