feat(isFloat) Fix , passing as float by frederike-ramin · Pull Request #2020 · validatorjs/validator.js

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

frederike-ramin · 2022-08-08T09:52:45Z

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2022-08-08T09:54:52Z

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2203 2203 Branches 477 477 =========================================
Hits 2203 2203

Impacted Files	Coverage Δ
src/lib/isFloat.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

frederike-ramin · 2022-10-04T11:20:06Z

@rubiin do I still need to do anything to have this PR merged?

rubiin · 2022-10-17T14:22:30Z

Waiting for further approvals from @profnandaa

gibson042 · 2022-10-26T18:27:16Z

@@ -5,7 +5,7 @@ export default function isFloat(str, options) {
 assertString(str);
 options = options || {};
 const float = new RegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);


Suggested change
constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
// but not underscore separators
// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);
(and if you take this suggestion, then the following if is unnecessary)

profnandaa · 2023-02-02T03:28:39Z

merging in #2164

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

Fix , passing as float
8db790f

WikiRik approved these changes Aug 8, 2022
View reviewed changes

rubiin approved these changes Aug 9, 2022
View reviewed changes

rubiin added the ✅ LGTM label Aug 9, 2022

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr and removed ✅ LGTM labels Oct 20, 2022

PantheraRed mentioned this pull request Oct 25, 2022
isFloat() returns true when a combination of sign and decimal separator is passed #2090
Open

gibson042 reviewed Oct 26, 2022
View reviewed changes

profnandaa approved these changes Feb 1, 2023
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023

profnandaa closed this Feb 2, 2023

profnandaa added the PR/combined label Feb 2, 2023

libra-exlaBot mentioned this pull request May 31, 2026
isFloat() returns true when a combination of sign and decimal separator is passed viraatdas/validator.js#4
Open

-constfloat=newRegExp(`^(?:[-+])?(?:[0-9]+)?(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][\\+\\-]?(?:[0-9]+))?$`);
+// largely derived from ECMAScript, with optional leading sign and allowing unnecessary leading zeroes
+// but not underscore separators
+// https://tc39.es/ecma262/multipage/ecmascript-language-lexical-grammar.html#prod-DecimalLiteral
+constfloat=newRegExp(`^[-+]?(?:[0-9]+|(?=.[0-9]))(?:\\${options.locale ? decimal[options.locale] : '.'}[0-9]*)?(?:[eE][-+]?[0-9]+)?$`);

Uh oh!

Uh oh!

Conversation

frederike-ramin commented Aug 8, 2022

Checklist

Uh oh!

codecovBot commented Aug 8, 2022

Codecov Report

Uh oh!

frederike-ramin commented Oct 4, 2022

Uh oh!

rubiin commented Oct 17, 2022

Uh oh!

gibson042Oct 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

profnandaa commented Feb 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

frederike-ramin commented Aug 8, 2022

Checklist

Uh oh!

codecovBot commented Aug 8, 2022

Codecov Report

Uh oh!

frederike-ramin commented Oct 4, 2022

Uh oh!

rubiin commented Oct 17, 2022

Uh oh!

gibson042Oct 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

profnandaa commented Feb 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

frederike-ramin commented Aug 8, 2022

Checklist

Uh oh!

codecovBot commented Aug 8, 2022

Codecov Report

Uh oh!

frederike-ramin commented Oct 4, 2022

Uh oh!

rubiin commented Oct 17, 2022

Uh oh!

gibson042Oct 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

profnandaa commented Feb 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

gibson042Oct 26, 2022•
edited
Loading

gibson042Oct 26, 2022•
edited
Loading

gibson042Oct 26, 2022•
edited
Loading

gibson042Oct 26, 2022•
edited
Loading

gibson042Oct 26, 2022•
edited
Loading